[Fonts] Update icons #108858
[Fonts] Update icons #108858
Conversation
flutter-dashboard
bot
added
f: material design
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| data: const IconThemeData(size: 200), | ||
| child: Wrap( | ||
| children: const <Icon>[ | ||
| Icon(Icons.repeat_on), |
There was a problem hiding this comment.
Are these just a sampling of the new icons or were the chosen for a specific purpose? Should we have a test that uses all the new ones? Or is that too onerous?
There was a problem hiding this comment.
These are the ones that had an issue associated with them. There are too many icons to test so I usually just add a sample.
* Update icons * Update icons_test.dart
This reverts commit ba40150.
2 participants
Adds 113 new icons.
Fixes #103202
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.