Skip to content

Replace empty Container with const SizedBox #108672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 13 commits into from
Aug 19, 2022
Merged

Replace empty Container with const SizedBox #108672

auto-submit merged 13 commits into from
Aug 19, 2022

Conversation

@tgucio
Copy link
Contributor

@tgucio tgucio commented Jul 30, 2022 •
edited
Loading

This PR replaces the use of Container() for empty widgets with const SizedBox() or SizedBox.shrink() in a couple of places so new instances aren't created in each build.

Also changes SizedBox.shrink(width: 0.0, height: 0.0) to SizedBox.shrink().

Test exempt: minor optimisation only.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jul 30, 2022
@flutter-dashboard
Copy link

flutter-dashboard bot commented Jul 30, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@tgucio tgucio changed the title Replace empty Container() with const SizedBox.shrink() Replace empty Container with const SizedBox Jul 30, 2022
@Hixie
Copy link
Contributor

Hixie commented Aug 8, 2022

test-exempt: code refactor with no semantic change

@tgucio
Copy link
Contributor Author

tgucio commented Aug 10, 2022 •
edited
Loading

/cc @a14n based on dart-archive/linter#2049 :)

justinmc
justinmc approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks for cleaning this up!

Renzo-Olivares
Renzo-Olivares approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Renzo-Olivares Renzo-Olivares added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 18, 2022
@auto-submit auto-submit bot merged commit 75ee440 into flutter:master Aug 19, 2022
This was referenced Aug 19, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 19, 2022
@engine-flutter-autoroll
75ee440 Replace empty Container with const SizedBox (flutter/flutter#…
32e3e26 
…108672)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 19, 2022
@engine-flutter-autoroll
75ee440 Replace empty Container with const SizedBox (flutter/flutter#…
51b15b2 
…108672)
@tgucio tgucio deleted the use-const-sizedbox branch August 30, 2022 07:45
This was referenced Feb 23, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

@Renzo-Olivares Renzo-Olivares Renzo-Olivares approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tgucio @Hixie @justinmc @Renzo-Olivares