Skip to content

Typo in Documentation for Restoration with didChangeDependencies #108659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Aug 5, 2022
Merged

Typo in Documentation for Restoration with didChangeDependencies #108659

auto-submit merged 2 commits into from
Aug 5, 2022

Conversation

@Stitch-Taotao
Copy link
Contributor

@Stitch-Taotao Stitch-Taotao commented Jul 30, 2022 •
edited
Loading

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Jul 30, 2022
@google-cla
Copy link

google-cla bot commented Jul 30, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Stitch-Taotao
spell mistake i think。
b53eac6 
Revert "spell mistake i think。"

This reverts commit 8ecec85cb4fd727122253b43b6ea9c69f29df261.

spell mistake。
@Stitch-Taotao
Copy link
Contributor Author

Stitch-Taotao commented Jul 31, 2022

I had sign the CLA , can you merge this PR?

goderbauer
goderbauer approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the fix!

gspencergoog
gspencergoog approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 2, 2022
youssef-attia
youssef-attia approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@youssef-attia youssef-attia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youssef-attia youssef-attia changed the title I think it real mean maybe didChangeDependencies Typo in Documentation for Restoration with didChangeDependencies Aug 2, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 2, 2022

  • The status or check suite Linux flutter_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 2, 2022
youssef-attia
youssef-attia suggested changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@youssef-attia youssef-attia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to fetch upstream in your fork. It is several commits behind and that is likely the reason some checks are failing.

@youssef-attia youssef-attia added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 5, 2022
@auto-submit auto-submit bot merged commit f1f559d into flutter:master Aug 5, 2022
This was referenced Aug 6, 2022
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2022
@engine-flutter-autoroll
f1f559d Typo in Documentation for Restoration with didChangeDependenc…
8adb751 
…ies (flutter/flutter#108659)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 6, 2022
@engine-flutter-autoroll
f1f559d Typo in Documentation for Restoration with didChangeDependenc…
3a0b86b 
…ies (flutter/flutter#108659)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2022
@engine-flutter-autoroll
f1f559d Typo in Documentation for Restoration with didChangeDependenc…
43072fe 
…ies (flutter/flutter#108659)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2022
@engine-flutter-autoroll
f1f559d Typo in Documentation for Restoration with didChangeDependenc…
6592fb5 
…ies (flutter/flutter#108659)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 7, 2022
@engine-flutter-autoroll
f1f559d Typo in Documentation for Restoration with didChangeDependenc…
4e17542 
…ies (flutter/flutter#108659)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 7, 2022
@engine-flutter-autoroll
f1f559d Typo in Documentation for Restoration with didChangeDependenc…
2d7ca15 
…ies (flutter/flutter#108659)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 8, 2022
@engine-flutter-autoroll
f1f559d Typo in Documentation for Restoration with didChangeDependenc…
7199916 
…ies (flutter/flutter#108659)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 8, 2022
@engine-flutter-autoroll
f1f559d Typo in Documentation for Restoration with didChangeDependenc…
880e366 
…ies (flutter/flutter#108659)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 8, 2022
@engine-flutter-autoroll
f1f559d Typo in Documentation for Restoration with didChangeDependenc…
d59a85a 
…ies (flutter/flutter#108659)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 8, 2022
@engine-flutter-autoroll
f1f559d Typo in Documentation for Restoration with didChangeDependenc…
afb3283 
…ies (flutter/flutter#108659)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 8, 2022
@engine-flutter-autoroll
f1f559d Typo in Documentation for Restoration with didChangeDependenc…
385f593 
…ies (flutter/flutter#108659)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 8, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 8, 2022
@engine-flutter-autoroll
f1f559d Typo in Documentation for Restoration with didChangeDependenc…
fc2b6aa 
…ies (flutter/flutter#108659)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@Stitch-Taotao @camsim99
Typo in Documentation for Restoration with didChangeDependencies (flu…
754131d 
…tter#108659)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@gspencergoog gspencergoog gspencergoog approved these changes

+1 more reviewer

@youssef-attia youssef-attia youssef-attia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Stitch-Taotao @goderbauer @gspencergoog @youssef-attia