Skip to content

Use hasNoRemainingExpectations matcher for fake process manager in tool tests #108649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Jul 30, 2022
Merged

Use hasNoRemainingExpectations matcher for fake process manager in tool tests #108649

auto-submit merged 1 commit into from
Jul 30, 2022

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Jul 29, 2022

expect(fakeProcessManager.hasRemainingExpectations, isFalse) failures look like:

Expected: false
  Actual: <true>

Using the _HasNoRemainingExpectations matcher, expect(fakeProcessManager, hasNoRemainingExpectations) says which command expectations are remaining.

  Expected: a fake process manager with no remaining expectations
    Actual: <Instance of '_SequenceProcessManager'>
     Which: has remaining expectations:
            [the, command]

flutter/packages/flutter_tools/test/src/fake_process_manager.dart

Lines 456 to 465 in f852c46

Description describeMismatch(
dynamic item,
Description description,
Map<dynamic, dynamic> matchState,
bool verbose,
) {
final FakeProcessManager fakeProcessManager = item as FakeProcessManager;
return description.add(
'has remaining expectations:\n${fakeProcessManager._remainingExpectations.map((FakeCommand command) => command.command).join('\n')}');
}

Switch false/isFalse matcher to hasNoRemainingExpectations everywhere.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 29, 2022
@jmagman jmagman self-assigned this Jul 29, 2022
@jmagman jmagman mentioned this pull request Jul 29, 2022
Merged
8 tasks
christopherfujino
christopherfujino approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've been trying to fix these as I see them (but then again, I probably added a lot of these)

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 30, 2022
@auto-submit auto-submit bot merged commit 7c7ae99 into flutter:master Jul 30, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 30, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 30, 2022
@engine-flutter-autoroll
7c7ae99 Use hasNoRemainingExpectations matcher for fake process man…
eda8d4f 
…ager in tool tests (flutter/flutter#108649)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 30, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 30, 2022
@engine-flutter-autoroll
7c7ae99 Use hasNoRemainingExpectations matcher for fake process man…
713fd72 
…ager in tool tests (flutter/flutter#108649)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 30, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 30, 2022
@engine-flutter-autoroll
7c7ae99 Use hasNoRemainingExpectations matcher for fake process man…
18185e4 
…ager in tool tests (flutter/flutter#108649)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@jmagman @camsim99
Use hasNoRemainingExpectations matcher for fake process manager in …
551606b 
…tool tests (flutter#108649)
@jmagman jmagman deleted the hasNoRemainingExpectations branch August 31, 2022 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmagman @christopherfujino