Skip to content

analytics expects a format of cd<integer> for custom dimensions #10864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sethladd merged 1 commit into from
Jun 21, 2017
Merged

analytics expects a format of cd<integer> for custom dimensions #10864

sethladd merged 1 commit into from
Jun 21, 2017

Conversation

@sethladd
Copy link
Contributor

@sethladd sethladd commented Jun 20, 2017

Fixes #10582

@sethladd sethladd requested a review from goderbauer June 20, 2017 21:59
@sethladd sethladd requested a review from devoncarew June 20, 2017 21:59
@sethladd
Copy link
Contributor Author

sethladd commented Jun 20, 2017

cc @goderbauer @devoncarew

goderbauer
goderbauer approved these changes Jun 20, 2017
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for tracking it down!

@eseidelGoogle
Copy link
Contributor

eseidelGoogle commented Jun 21, 2017

Failure seems like an unrelated flake:

02:47 +123 -1: test\commands\packages_test.dart: packages get/upgrade get [E]
  TimeoutException after 0:00:30.000000: Test timed out after 30 seconds.
  dart:isolate  _RawReceivePortImpl._handleMessage
  
  FileSystemException: Deletion failed, path = 'C:\Users\appveyor\AppData\Local\Temp\1\flutter_tools61412c1c-5604-11e7-81a2-00155d2036e9' (OS Error: The process cannot access the file because it is being used by another process.
  , errno = 32)
  dart:io                                                               FileSystemEntity.deleteSync
  package:file/src/forwarding/forwarding_file_system_entity.dart 68:16  ForwardingFileSystemEntity.deleteSync
  test\commands\packages_test.dart 28:12                                main.<fn>.<fn>

@sethladd sethladd merged commit b231006 into flutter:master Jun 21, 2017
@sethladd sethladd deleted the host-os-details branch June 21, 2017 17:54
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jul 1, 2017
@sethladd @gspencergoog
analytics expects a format of cd<integer> for custom dimensions (flut…
ec2aedc 
…ter#10864)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@goderbauer goderbauer goderbauer approved these changes

+1 more reviewer

@devoncarew devoncarew devoncarew approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

We'd like to know what host OS version our users are using

5 participants

@sethladd @eseidelGoogle @goderbauer @devoncarew @googlebot