Skip to content

Add onTapOutside to TextFormField #108629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Jul 29, 2022
Merged

Add onTapOutside to TextFormField #108629

auto-submit merged 1 commit into from
Jul 29, 2022

Conversation

@gspencergoog
Copy link
Contributor

@gspencergoog gspencergoog commented Jul 29, 2022 •
edited
Loading

Description

This adds onTapOutside to TextFormField, which I overlooked in the original TapRegion PR.

Tests

  • Added a test specific to TextFormField to make sure it uses onTapOutside.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jul 29, 2022
@gspencergoog gspencergoog requested a review from justinmc July 29, 2022 16:14
justinmc
justinmc approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 29, 2022
@auto-submit auto-submit bot merged commit 5532775 into flutter:master Jul 29, 2022
@gspencergoog gspencergoog deleted the focus_trap_fix branch July 29, 2022 20:07
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 30, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 30, 2022
@engine-flutter-autoroll
5532775 Add onTapOutside to TextFormField (flutter/flutter#108629)
27660fd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 30, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 30, 2022
@engine-flutter-autoroll
5532775 Add onTapOutside to TextFormField (flutter/flutter#108629)
69be47d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 30, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 30, 2022
@engine-flutter-autoroll
5532775 Add onTapOutside to TextFormField (flutter/flutter#108629)
7d0c789
gspencergoog added a commit to gspencergoog/flutter that referenced this pull request Aug 2, 2022
@gspencergoog
Revert "Add onTapOutside to TextFormField (flutter#108629)"
b51b43d 
This reverts commit 5532775 because TapRegion was reverted
@gspencergoog gspencergoog mentioned this pull request Aug 2, 2022
Closed
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@gspencergoog @camsim99
Add onTapOutside to TextFormField (flutter#108629)
3b070fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gspencergoog @justinmc