Use a lookup table to calculate the number of days in a month #10860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Hixie
reviewed
Jun 20, 2017
Contributor
There was a problem hiding this comment.
this is entirely up to you but i would be tempted to make _kDaysInMonth[1] have the value -1, and then make _daysInMonth return 29 if isLeapYear is true and 28 otherwise. That way anyone tempted to use _kDaysInMonth would immediately find that they'd forgotten about leap years. Also maybe add a comment next to _kDaysInMonth pointing to _daysInMonth.
Contributor
|
Needs tests, then LGTM. |
Member
Author
|
done - PTAL |
Contributor
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10541