Skip to content

Add an example for how to hide default scrollbar on desktop platform. #108542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Aug 18, 2022
Merged

Add an example for how to hide default scrollbar on desktop platform. #108542

auto-submit merged 1 commit into from
Aug 18, 2022

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Jul 28, 2022

fixes #108159

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jul 28, 2022
@TahaTesser TahaTesser requested a review from Piinks July 28, 2022 14:04
Piinks
Piinks reviewed Aug 1, 2022
View reviewed changes
@TahaTesser TahaTesser force-pushed the scroll_desktop_example branch 2 times, most recently from 3adadfb to 7dd5bda Compare August 2, 2022 09:56
@goderbauer goderbauer requested a review from Piinks August 2, 2022 22:15
Piinks
Piinks approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM

Welcome back from vacation! 🌴

@Piinks
Copy link
Contributor

Piinks commented Aug 16, 2022

Can you update this with the latest from master before merging? There were some recent updates to ``` code analysis, updating will make sure this does not get reverted if there is an issue. :)

https://discord.com/channels/608014603317936148/608116355836805126/1007046877994303638

@TahaTesser TahaTesser force-pushed the scroll_desktop_example branch from 7dd5bda to 7db0015 Compare August 18, 2022 12:27
@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 18, 2022
@auto-submit auto-submit bot merged commit 9da693e into flutter:master Aug 18, 2022
@TahaTesser TahaTesser deleted the scroll_desktop_example branch August 18, 2022 13:09
This was referenced Aug 18, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2022
@engine-flutter-autoroll
9da693e Add an example for how to hide default scrollbar on desktop p…
8d4aef8 
…latform. (flutter/flutter#108542)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 18, 2022
@engine-flutter-autoroll
9da693e Add an example for how to hide default scrollbar on desktop p…
406fad6 
…latform. (flutter/flutter#108542)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document the correct solution to avoid duplicate Scrollbar's on desktop

2 participants

@TahaTesser @Piinks