Added InputDecoration helperText, helperStyle #10852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
reviewed
Jun 20, 2017
| if (labelText != null) | ||
| description.add('labelText: "$labelText"'); | ||
| if (helperText != null) | ||
| description.add('hellperText: "$helperText"'); |
Hixie
reviewed
Jun 20, 2017
| errorText, | ||
| style: errorStyle, | ||
| errorText ?? helperText, | ||
| style: subtextStyle, |
Contributor
There was a problem hiding this comment.
Should we be animating this stuff?
Contributor
Author
There was a problem hiding this comment.
We could cross fade between the error and helper text, and animate the divider's color change. I'll file an issue.
Contributor
|
|
This was referenced Jun 20, 2017
Closed
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jul 1, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If helper text is specified it appears below the input field, where the error text appears.
If both helper and error text are specified, the error text and its red divider, are displayed.
Fixes #10807