Skip to content

Add StarBorder and StarBorder.polygon, with example. #108489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 4 commits into from
Jul 28, 2022
Merged

Add StarBorder and StarBorder.polygon, with example. #108489

auto-submit merged 4 commits into from
Jul 28, 2022

Conversation

@gspencergoog
Copy link
Contributor

@gspencergoog gspencergoog commented Jul 27, 2022

Description

This PR replaces #107979 because Gold got really confused by my force-pushing things.

This adds StarBorder, along with the interpolations to/from CircleBorder, RoundedRectBorder, and StadiumBorder.

The example looks like this Dartpad. (If it won't load because GitHub's API is overloaded, copy the Gist here into your own DartPad).

Related Issues

Tests

  • Tests written for all the new borders and lerps.

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jul 27, 2022
@gspencergoog gspencergoog requested a review from Piinks July 27, 2022 22:11
@gspencergoog gspencergoog mentioned this pull request Jul 27, 2022
Closed
Piinks
Piinks approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches previous PR. LGTM!

@flutter-dashboard
Copy link

flutter-dashboard bot commented Jul 27, 2022

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #108489 at sha d432f55

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Jul 27, 2022
@gspencergoog gspencergoog added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Jul 27, 2022
@auto-submit auto-submit bot merged commit 07de84f into flutter:master Jul 28, 2022
This was referenced Jul 28, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 28, 2022
@engine-flutter-autoroll
07de84f Add StarBorder and StarBorder.polygon, with example. (flutter…
5af8f9d 
…/flutter#108489)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 28, 2022
@engine-flutter-autoroll
07de84f Add StarBorder and StarBorder.polygon, with example. (flutter…
1cf7947 
…/flutter#108489)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@gspencergoog @camsim99
Add StarBorder and StarBorder.polygon, with example. (flutter#108489)
f2b4fd7
@TKDev7
Copy link

TKDev7 commented Oct 23, 2022 •
edited
Loading

@gspencergoog Great stuff! I was wondering if perhaps you could extract StarBorder.polygon into its own PolygonBorder class maybe? Also maybe add a new PolygonBorderSide so we can style individual sides of the polygon

@gspencergoog
Copy link
Contributor Author

gspencergoog commented Oct 24, 2022

@MrHBS I thought about that, but I decided not to because of the combinatoric explosion of the lerp functions: each new border class we introduce expands the number of necessary lerpTo and lerpFrom methods we need to write exponentially.

Styling individual sides is interesting, though, I'll think about that. Could you file a feature request issue, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. will affect goldens Changes to golden files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Request] Scallop / Sunflower / Star Material 3 Shape

3 participants

@gspencergoog @TKDev7 @Piinks