change --machine flag for flutter test to report test progress as JSON
#10848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(The Flutter plugin will use this to update the UI with test progress.)
Contributor
Author
Contributor
|
lgtm |
tvolkert
reviewed
Jun 20, 2017
| startPaused: startPaused, | ||
| ipv6: argResults['ipv6']); | ||
| ipv6: argResults['ipv6'], | ||
| json: machine); |
Contributor
There was a problem hiding this comment.
Nit: maybe put a trailing comma and the closing parens on a new line so future changes only have to affect one line.
tvolkert
reviewed
Jun 20, 2017
| } | ||
|
|
||
| if (json) { | ||
| testArgs.addAll(<String>["-r", "json"]); |
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jul 1, 2017
…SON (flutter#10848) (The Flutter plugin will use this to update the UI with test progress.)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so that the IntelliJ Flutter plugin can report test progress using a nice UI.