-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Reland "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate benchmarks+examples" #108355 #108472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
One more time, Hopefully it sticks this time. Verified all lockfiles are in place for every project changed. |
zanderso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rslgtm 🤞🏻
christopherfujino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
|
Looks like this is breaking the tree again. |
|
@zanderso is quicker on the draw again! 😛 |
|
Is there a good way to run all the postsubmit tests in a PR on CI? I'd like to avoid more PR bouncing if possible |
I believe this is difficult and requires a bunch of infra changes to understand the branch you want to test, but cc @keyonghan just in case he can suggest an easy way. |
I remember implementing the flag |
That is true. I would suggest You may want to run this with a lower priority (40) to avoid affecting PROD queue time. |
…e benchmarks+examples" #108355 (flutter/flutter#108472)
…e benchmarks+examples" #108355 (flutter/flutter#108472)
…e benchmarks+examples" flutter#108355 (flutter#108472)" (flutter#108488) This reverts commit 1f8c490.
Relands #108355, previous version missed updating lockfiles for
benchmarks/platform_views_layoutdue to v1 embedding warning.