Skip to content

Unify analysis options #108462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
goderbauer merged 3 commits into from
Jul 28, 2022
Merged

Unify analysis options #108462

goderbauer merged 3 commits into from
Jul 28, 2022

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Jul 27, 2022

curly_braces_in_flow_control_structures was already enabled for most parts of the repository. This enables it for the entire repository as there is no real need for enforcing different styles for different parts of the repository.

@goderbauer goderbauer requested a review from guidezpl July 27, 2022 17:02
@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: animation Animation APIs a: text input Entering text in a text field or keyboard related problems d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: focus Focus traversal, gaining or losing focus f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Jul 27, 2022
guidezpl
guidezpl approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  _    ___ _____ __  __ 
 | |  / __|_   _|  \/  |
 | |_| (_ | | | | |\/| |
 |____\___| |_| |_|  |_|

@goderbauer goderbauer merged commit 10a7c9b into flutter:master Jul 28, 2022
@goderbauer goderbauer deleted the unifyAnalsis branch July 28, 2022 16:07
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 29, 2022
@engine-flutter-autoroll
10a7c9b Unify analysis options (flutter/flutter#108462)
3305fcd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 29, 2022
@engine-flutter-autoroll
10a7c9b Unify analysis options (flutter/flutter#108462)
7f5d479
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@goderbauer @camsim99
Unify analysis options (flutter#108462)
0efa9dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guidezpl guidezpl guidezpl approved these changes

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: animation Animation APIs a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: focus Focus traversal, gaining or losing focus f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@goderbauer @guidezpl