Clean up pre-existing DevFS during creation #10843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvolkert
reviewed
Jun 19, 2017
Contributor
tvolkert
left a comment
tvolkert
left a comment
There was a problem hiding this comment.
Can you add a test to devfs_test.dart please?
Member
Author
|
Done |
Member
Author
|
Friendly ping. |
Member
Author
|
Thanks! |
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jul 1, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connecting to a flaky device, or a device with a flaky network stack, flutter_tool can exit without any opportunity to clean up the DevFS on the device. However, users are expecting reconnections to work. Currently they fail when flutter_tool notices that the target VM already has a DevFS set up.
In this case, this CL cleans up the existing DevFS, and sets up a new one. This CL also avoids trying to connect to a bogus port on a Fuchsia devices.