Skip to content

Removed references to deprecated styleFrom parameters. #108401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Jul 27, 2022
Merged

Removed references to deprecated styleFrom parameters. #108401

auto-submit merged 1 commit into from
Jul 27, 2022

Conversation

@darrenaustin
Copy link
Contributor

@darrenaustin darrenaustin commented Jul 26, 2022

There were still several references to the *Button.styleFrom parameters that were deprecated in #105291 in both the docs and some examples. This PR hopefully updates them all to point to the replacement parameters.

Fixes: #108333

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jul 26, 2022
HansMuller
HansMuller approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darrenaustin darrenaustin added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 27, 2022
@auto-submit auto-submit bot merged commit 4c104ef into flutter:master Jul 27, 2022
@darrenaustin darrenaustin deleted the style_from_docs branch July 27, 2022 06:06
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 27, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 27, 2022
@engine-flutter-autoroll
4c104ef Removed references to deprecated styleFrom parameters. (flutt…
e399975 
…er/flutter#108401)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 28, 2022
@engine-flutter-autoroll
4c104ef Removed references to deprecated styleFrom parameters. (flutt…
03b0e27 
…er/flutter#108401)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@darrenaustin @camsim99
Removed references to deprecated styleFrom parameters. (flutter#108401)
96482e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guidezpl guidezpl Awaiting requested review from guidezpl

1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TextButton et al have docs that still refer to the deprecated primary parameters

2 participants

@darrenaustin @HansMuller