Re-enable use of instruments for iOS device lookup #10838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b2909a2. This resubmits the following patches: 1. Use Xcode instruments to list devices (flutter#10801) Eliminates the dependency on idevice_id from libimobiledevice. Instead, uses Xcode built-in functionality. 2. Make device discovery asynchronous (flutter#10803) Migrates DeviceDiscovery.devices and all device-specific lookup to be asynchronous.
tvolkert
approved these changes
Jun 19, 2017
Member
Author
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jul 1, 2017
This reverts commit b2909a2. This resubmits the following patches: 1. Use Xcode instruments to list devices (flutter#10801) Eliminates the dependency on idevice_id from libimobiledevice. Instead, uses Xcode built-in functionality. 2. Make device discovery asynchronous (flutter#10803) Migrates DeviceDiscovery.devices and all device-specific lookup to be asynchronous.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b2909a2.
This resubmits the following patches:
Use Xcode instruments to list devices (Use Xcode instruments to list devices #10801)
Eliminates the dependency on idevice_id from libimobiledevice. Instead,
uses Xcode built-in functionality.
Make device discovery asynchronous (Make device discovery asynchronous #10803)
Migrates DeviceDiscovery.devices and all device-specific lookup to be
asynchronous.
The above patches were reverted due to incomplete Xcode installs on the
build bots. This has now been remedies.