-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Reland "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate benchmarks+examples" #108355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR downgrades some pub packages, was that intended? |
|
No, thanks for the heads up, it made it in there due to outdated checkout. Needed to fetch latest master. |
| @@ -1,120 +0,0 @@ | |||
| # This is a Gradle generated file for dependency locking. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this lockfile deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script seems to have failed on this project, I fixed it and reran.
christopherfujino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…e benchmarks+examples" (flutter/flutter#108355)
…e benchmarks+examples" (flutter/flutter#108355)
…e benchmarks+examples" (flutter#108355)" (flutter#108407) This reverts commit c4b3625.
…e benchmarks+examples" flutter#108355 (flutter#108472)" (flutter#108488) This reverts commit 1f8c490.
Relands #108197
This version uses the gradle file generation script under
dev/tools/binfor the benchmarks directory and updates lockfiles across the board.