Skip to content

Conversation

@GaryQian
Copy link
Contributor

@GaryQian GaryQian commented Jul 26, 2022

Relands #108197

This version uses the gradle file generation script under dev/tools/bin for the benchmarks directory and updates lockfiles across the board.

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Jul 26, 2022
@GaryQian GaryQian changed the title Reland "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests" Reland "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate benchmarks/examples/tests" Jul 26, 2022
@GaryQian GaryQian changed the title Reland "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate benchmarks/examples/tests" Reland "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate benchmarks+examples" Jul 26, 2022
@GaryQian GaryQian requested a review from keyonghan as a code owner July 26, 2022 10:04
@christopherfujino
Copy link
Contributor

Looks like this PR downgrades some pub packages, was that intended?

@GaryQian
Copy link
Contributor Author

No, thanks for the heads up, it made it in there due to outdated checkout. Needed to fetch latest master.

@@ -1,120 +0,0 @@
# This is a Gradle generated file for dependency locking.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this lockfile deleted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script seems to have failed on this project, I fixed it and reran.

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit c4b3625 into flutter:master Jul 26, 2022
zanderso added a commit that referenced this pull request Jul 27, 2022
zanderso added a commit that referenced this pull request Jul 27, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 27, 2022
Piinks added a commit that referenced this pull request Jul 27, 2022
Piinks added a commit that referenced this pull request Jul 27, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 28, 2022
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants