Revert "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests" #108349

zanderso · 2022-07-26T05:13:31Z

Failing consistently on Mac_android microbenchmarks:

[microbenchmarks] [STDOUT] [STDOUT] [+1142 ms] > Configure project :
[microbenchmarks] [STDOUT] [STDOUT] [        ] Evaluating root project 'android' using build file '/opt/s/w/ir/x/w/recipe_cleanup/tmp17zz_ptv/flutter sdk/dev/benchmarks/microbenchmarks/android/build.gradle'.
[microbenchmarks] [STDOUT] [STDOUT] [        ] Resource missing. [HTTP GET: https://dl.google.com/dl/android/maven2/com/android/tools/build/gradle/%7B%7BagpVersion%7D%7D/gradle-%7B%7BagpVersion%7D%7D.pom]
[microbenchmarks] [STDOUT] [STDOUT] [        ] Resource missing. [HTTP GET: https://repo.maven.apache.org/maven2/com/android/tools/build/gradle/%7B%7BagpVersion%7D%7D/gradle-%7B%7BagpVersion%7D%7D.pom]
[microbenchmarks] [STDOUT] [STDOUT] [+2222 ms] Running Gradle task 'assembleProfile'... (completed in 6.6s)
[microbenchmarks] [STDOUT] [STDOUT] [   +3 ms] "flutter run" took 7,347ms.
[microbenchmarks] [STDOUT] [STDOUT] [   +1 ms] ensureAnalyticsSent: 0ms
[microbenchmarks] [STDOUT] [STDOUT] [        ] Running shutdown hooks
[microbenchmarks] [STDOUT] [STDOUT] [        ] Shutdown hooks complete
[microbenchmarks] [STDOUT] [STDOUT] [        ] exiting with code 1

…es/tests (#108197)" This reverts commit ca6cecf.

auto-submit · 2022-07-26T05:17:06Z

Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

auto-submit · 2022-07-26T05:17:07Z

Validations Fail.

zanderso · 2022-07-26T05:22:37Z

Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@keyonghan @godofredoc Team members should be able to land reverts to green the tree without waiting for approval.

…e examples/tests (#108197)" (flutter/flutter#108349)

godofredoc · 2022-07-26T15:55:24Z

Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@keyonghan @godofredoc Team members should be able to land reverts to green the tree without waiting for approval.

@ricardoamador is working on a revert api that will allow to implement that functionality. Unfortunately github does not provide any api to differentiate regular PRs from reverts.

…e examples/tests (#108197)" (flutter/flutter#108349)

* 2142b2e Roll Flutter Engine from cd7e2ec4037b to c31036f2381c (1 revision) (flutter/flutter#108299) * 178e444 Revert "Add optional flag to determine assertiveness level in aria announcement for flutter web" (flutter/flutter#108262) * 8a7b359 flutter update-packages --force-upgrade + analyzer fix (flutter/flutter#108198) * b3f5d3f Roll Flutter Engine from c31036f2381c to 54b0ac3059bf (1 revision) (flutter/flutter#108302) * 2f4299a [flutter_tools] Remove unused parameter when connected DAP to VM Service (flutter/flutter#108285) * e74b9b5 Migrate InputDecorator to Material 3 (flutter/flutter#107943) * e3b851a Fix Tamil DateTime representation of AM/PM (flutter/flutter#108185) * 43d6e2b Roll Flutter Engine from 54b0ac3059bf to 705072522c00 (4 revisions) (flutter/flutter#108308) * 6929ad1 Roll Flutter Engine from 705072522c00 to 3964cf62cdf8 (1 revision) (flutter/flutter#108316) * 5f67b47 [iOS] Update template icons (flutter/flutter#107873) * 606954d Added iconSize parameter in ButtonStyle (flutter/flutter#108268) * b3814c7 Roll Flutter Engine from 3964cf62cdf8 to 7f8925b1f6f3 (2 revisions) (flutter/flutter#108320) * ca6cecf Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests (flutter/flutter#108197) * d155bc1 Revert "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests (#108197)" (flutter/flutter#108349) * 4056d3f Explain the "patching" protocol in `KeyMessageManager.keyMessageHandler` and add an example (flutter/flutter#105280) * b035ef1 [flutter_tools] Remove more shuffles (flutter/flutter#107759) * be14858 Roll Flutter Engine from 7f8925b1f6f3 to 8eca26d130a2 (1 revision) (flutter/flutter#108326) * 3eb638f Roll Flutter Engine from 8eca26d130a2 to f1f9b4de82b6 (5 revisions) (flutter/flutter#108350) * 401b556 Roll Flutter Engine from f1f9b4de82b6 to 11d927ac3e9b (2 revisions) (flutter/flutter#108353) * 925bee9 Roll Flutter Engine from 11d927ac3e9b to 5dcaeae6561b (1 revision) (flutter/flutter#108356) * 5d31b07 [flutter_tools] [dap] Ensure DAP sends app.stop/app.detach during terminate (flutter/flutter#108310) * c8b5d10 Roll Flutter Engine from 5dcaeae6561b to 89e117b89c63 (1 revision) (flutter/flutter#108367) * e3d08fb Hide the debug banner in the PopupMenuButton example (flutter/flutter#108324)

…es/tests (flutter#108197)" (flutter#108349) This reverts commit ca6cecf.

* 2142b2e Roll Flutter Engine from cd7e2ec4037b to c31036f2381c (1 revision) (flutter/flutter#108299) * 178e444 Revert "Add optional flag to determine assertiveness level in aria announcement for flutter web" (flutter/flutter#108262) * 8a7b359 flutter update-packages --force-upgrade + analyzer fix (flutter/flutter#108198) * b3f5d3f Roll Flutter Engine from c31036f2381c to 54b0ac3059bf (1 revision) (flutter/flutter#108302) * 2f4299a [flutter_tools] Remove unused parameter when connected DAP to VM Service (flutter/flutter#108285) * e74b9b5 Migrate InputDecorator to Material 3 (flutter/flutter#107943) * e3b851a Fix Tamil DateTime representation of AM/PM (flutter/flutter#108185) * 43d6e2b Roll Flutter Engine from 54b0ac3059bf to 705072522c00 (4 revisions) (flutter/flutter#108308) * 6929ad1 Roll Flutter Engine from 705072522c00 to 3964cf62cdf8 (1 revision) (flutter/flutter#108316) * 5f67b47 [iOS] Update template icons (flutter/flutter#107873) * 606954d Added iconSize parameter in ButtonStyle (flutter/flutter#108268) * b3814c7 Roll Flutter Engine from 3964cf62cdf8 to 7f8925b1f6f3 (2 revisions) (flutter/flutter#108320) * ca6cecf Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests (flutter/flutter#108197) * d155bc1 Revert "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests (#108197)" (flutter/flutter#108349) * 4056d3f Explain the "patching" protocol in `KeyMessageManager.keyMessageHandler` and add an example (flutter/flutter#105280) * b035ef1 [flutter_tools] Remove more shuffles (flutter/flutter#107759) * be14858 Roll Flutter Engine from 7f8925b1f6f3 to 8eca26d130a2 (1 revision) (flutter/flutter#108326) * 3eb638f Roll Flutter Engine from 8eca26d130a2 to f1f9b4de82b6 (5 revisions) (flutter/flutter#108350) * 401b556 Roll Flutter Engine from f1f9b4de82b6 to 11d927ac3e9b (2 revisions) (flutter/flutter#108353) * 925bee9 Roll Flutter Engine from 11d927ac3e9b to 5dcaeae6561b (1 revision) (flutter/flutter#108356) * 5d31b07 [flutter_tools] [dap] Ensure DAP sends app.stop/app.detach during terminate (flutter/flutter#108310) * c8b5d10 Roll Flutter Engine from 5dcaeae6561b to 89e117b89c63 (1 revision) (flutter/flutter#108367) * e3d08fb Hide the debug banner in the PopupMenuButton example (flutter/flutter#108324)

Revert "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate exampl…

ee48416

…es/tests (#108197)" This reverts commit ca6cecf.

zanderso requested review from GaryQian and christopherfujino July 26, 2022 05:13

zanderso added warning: land on red to fix tree breakage autosubmit Merge PR when tree becomes green via auto submit App labels Jul 26, 2022

zanderso requested a review from Piinks July 26, 2022 05:15

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 26, 2022

GaryQian approved these changes Jul 26, 2022

View reviewed changes

zanderso merged commit d155bc1 into master Jul 26, 2022

zanderso deleted the revert-108197-gradle branch July 26, 2022 05:20

This was referenced Jul 26, 2022

Roll Flutter from fa39206a2a34 to e3d08fb6d325 (23 revisions) flutter/plugins#6147

Merged

Roll Flutter from bbec650b64bc to e3d08fb6d325 (197 revisions) flutter/packages#2383

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 26, 2022

d155bc1 Revert "Upgrade Gradle and AGP versions to 7.5/7.2 and migrat…

c3f7d02

…e examples/tests (#108197)" (flutter/flutter#108349)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022

d155bc1 Revert "Upgrade Gradle and AGP versions to 7.5/7.2 and migrat…

11cd561

…e examples/tests (#108197)" (flutter/flutter#108349)

zanderso mentioned this pull request Jul 26, 2022

Team members should be able to land reverts TBR #108374

Closed

engine-flutter-autoroll mentioned this pull request Jul 26, 2022

Roll Flutter from bbec650b64bc to 2f551d30086a (198 revisions) flutter/packages#2384

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022

d155bc1 Revert "Upgrade Gradle and AGP versions to 7.5/7.2 and migrat…

cce961c

…e examples/tests (#108197)" (flutter/flutter#108349)

engine-flutter-autoroll mentioned this pull request Jul 26, 2022

Roll Flutter from bbec650b64bc to 527ee1d7286e (199 revisions) flutter/packages#2387

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022

d155bc1 Revert "Upgrade Gradle and AGP versions to 7.5/7.2 and migrat…

a11f9a8

…e examples/tests (#108197)" (flutter/flutter#108349)

engine-flutter-autoroll mentioned this pull request Jul 26, 2022

Roll Flutter from bbec650b64bc to 87938cec4426 (200 revisions) flutter/packages#2389

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022

d155bc1 Revert "Upgrade Gradle and AGP versions to 7.5/7.2 and migrat…

ad263ef

…e examples/tests (#108197)" (flutter/flutter#108349)

engine-flutter-autoroll mentioned this pull request Jul 26, 2022

Roll Flutter from bbec650b64bc to e05ae3cac799 (202 revisions) flutter/packages#2390

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022

d155bc1 Revert "Upgrade Gradle and AGP versions to 7.5/7.2 and migrat…

c43c19b

…e examples/tests (#108197)" (flutter/flutter#108349)

engine-flutter-autoroll mentioned this pull request Jul 26, 2022

Roll Flutter from bbec650b64bc to fe16c206ea19 (203 revisions) flutter/packages#2391

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022

d155bc1 Revert "Upgrade Gradle and AGP versions to 7.5/7.2 and migrat…

f7c7617

…e examples/tests (#108197)" (flutter/flutter#108349)

camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022

Revert "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate exampl…

b2121d7

…es/tests (flutter#108197)" (flutter#108349) This reverts commit ca6cecf.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Revert "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests" #108349

Revert "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests" #108349

Uh oh!

zanderso commented Jul 26, 2022

Uh oh!

auto-submit bot commented Jul 26, 2022

Uh oh!

auto-submit bot commented Jul 26, 2022

Uh oh!

zanderso commented Jul 26, 2022

Uh oh!

godofredoc commented Jul 26, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Revert "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests" #108349

Revert "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests" #108349

Uh oh!

Conversation

zanderso commented Jul 26, 2022

Uh oh!

auto-submit bot commented Jul 26, 2022

Uh oh!

auto-submit bot commented Jul 26, 2022

Uh oh!

zanderso commented Jul 26, 2022

Uh oh!

godofredoc commented Jul 26, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants