Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests #108197

GaryQian · 2022-07-22T22:00:26Z

This upgrades the AGP and gradle version and migrates a subset of example+test apps to use dynamic gradle versions.

Previous gradle bump: #99723

Part of work to address #103230

christopherfujino · 2022-07-25T19:28:17Z

Doesn't look like this is working:

02:44 +12 ~2 -1: test/integration.shard/android_plugin_example_app_build_test.dart: FFI plugin example can be built using current Flutter Gradle plugin [E]                                            
  Exception: flutter build failed: 1
  
  FAILURE: Build failed with an exception.
  
  * What went wrong:
  A problem occurred configuring root project 'android'.
  > Could not resolve all files for configuration ':classpath'.
     > Could not find com.android.tools.build:gradle:{{agpVersion}}.
       Searched in the following locations:
         - [https://dl.google.com/dl/android/maven2/com/android/tools/build/gradle/{{agpVersion}}/gradle-{{agpVersion}}.pom](https://dl.google.com/dl/android/maven2/com/android/tools/build/gradle/%7b%7bagpVersion%7d%7d/gradle-%7b%7bagpVersion%7d%7d.pom)
         - [https://repo.maven.apache.org/maven2/com/android/tools/build/gradle/{{agpVersion}}/gradle-{{agpVersion}}.pom](https://repo.maven.apache.org/maven2/com/android/tools/build/gradle/%7b%7bagpVersion%7d%7d/gradle-%7b%7bagpVersion%7d%7d.pom)
       Required by:
           project :

christopherfujino

LGTM

…es/tests (#108197)" This reverts commit ca6cecf.

…es/tests (#108197)" (#108349) This reverts commit ca6cecf.

…es/tests (flutter/flutter#108197)

* 2142b2e Roll Flutter Engine from cd7e2ec4037b to c31036f2381c (1 revision) (flutter/flutter#108299) * 178e444 Revert "Add optional flag to determine assertiveness level in aria announcement for flutter web" (flutter/flutter#108262) * 8a7b359 flutter update-packages --force-upgrade + analyzer fix (flutter/flutter#108198) * b3f5d3f Roll Flutter Engine from c31036f2381c to 54b0ac3059bf (1 revision) (flutter/flutter#108302) * 2f4299a [flutter_tools] Remove unused parameter when connected DAP to VM Service (flutter/flutter#108285) * e74b9b5 Migrate InputDecorator to Material 3 (flutter/flutter#107943) * e3b851a Fix Tamil DateTime representation of AM/PM (flutter/flutter#108185) * 43d6e2b Roll Flutter Engine from 54b0ac3059bf to 705072522c00 (4 revisions) (flutter/flutter#108308) * 6929ad1 Roll Flutter Engine from 705072522c00 to 3964cf62cdf8 (1 revision) (flutter/flutter#108316) * 5f67b47 [iOS] Update template icons (flutter/flutter#107873) * 606954d Added iconSize parameter in ButtonStyle (flutter/flutter#108268) * b3814c7 Roll Flutter Engine from 3964cf62cdf8 to 7f8925b1f6f3 (2 revisions) (flutter/flutter#108320) * ca6cecf Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests (flutter/flutter#108197) * d155bc1 Revert "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests (#108197)" (flutter/flutter#108349) * 4056d3f Explain the "patching" protocol in `KeyMessageManager.keyMessageHandler` and add an example (flutter/flutter#105280) * b035ef1 [flutter_tools] Remove more shuffles (flutter/flutter#107759) * be14858 Roll Flutter Engine from 7f8925b1f6f3 to 8eca26d130a2 (1 revision) (flutter/flutter#108326) * 3eb638f Roll Flutter Engine from 8eca26d130a2 to f1f9b4de82b6 (5 revisions) (flutter/flutter#108350) * 401b556 Roll Flutter Engine from f1f9b4de82b6 to 11d927ac3e9b (2 revisions) (flutter/flutter#108353) * 925bee9 Roll Flutter Engine from 11d927ac3e9b to 5dcaeae6561b (1 revision) (flutter/flutter#108356) * 5d31b07 [flutter_tools] [dap] Ensure DAP sends app.stop/app.detach during terminate (flutter/flutter#108310) * c8b5d10 Roll Flutter Engine from 5dcaeae6561b to 89e117b89c63 (1 revision) (flutter/flutter#108367) * e3d08fb Hide the debug banner in the PopupMenuButton example (flutter/flutter#108324)

…flutter#108197)

…es/tests (flutter#108197)" (flutter#108349) This reverts commit ca6cecf.

* 2142b2e Roll Flutter Engine from cd7e2ec4037b to c31036f2381c (1 revision) (flutter/flutter#108299) * 178e444 Revert "Add optional flag to determine assertiveness level in aria announcement for flutter web" (flutter/flutter#108262) * 8a7b359 flutter update-packages --force-upgrade + analyzer fix (flutter/flutter#108198) * b3f5d3f Roll Flutter Engine from c31036f2381c to 54b0ac3059bf (1 revision) (flutter/flutter#108302) * 2f4299a [flutter_tools] Remove unused parameter when connected DAP to VM Service (flutter/flutter#108285) * e74b9b5 Migrate InputDecorator to Material 3 (flutter/flutter#107943) * e3b851a Fix Tamil DateTime representation of AM/PM (flutter/flutter#108185) * 43d6e2b Roll Flutter Engine from 54b0ac3059bf to 705072522c00 (4 revisions) (flutter/flutter#108308) * 6929ad1 Roll Flutter Engine from 705072522c00 to 3964cf62cdf8 (1 revision) (flutter/flutter#108316) * 5f67b47 [iOS] Update template icons (flutter/flutter#107873) * 606954d Added iconSize parameter in ButtonStyle (flutter/flutter#108268) * b3814c7 Roll Flutter Engine from 3964cf62cdf8 to 7f8925b1f6f3 (2 revisions) (flutter/flutter#108320) * ca6cecf Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests (flutter/flutter#108197) * d155bc1 Revert "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests (#108197)" (flutter/flutter#108349) * 4056d3f Explain the "patching" protocol in `KeyMessageManager.keyMessageHandler` and add an example (flutter/flutter#105280) * b035ef1 [flutter_tools] Remove more shuffles (flutter/flutter#107759) * be14858 Roll Flutter Engine from 7f8925b1f6f3 to 8eca26d130a2 (1 revision) (flutter/flutter#108326) * 3eb638f Roll Flutter Engine from 8eca26d130a2 to f1f9b4de82b6 (5 revisions) (flutter/flutter#108350) * 401b556 Roll Flutter Engine from f1f9b4de82b6 to 11d927ac3e9b (2 revisions) (flutter/flutter#108353) * 925bee9 Roll Flutter Engine from 11d927ac3e9b to 5dcaeae6561b (1 revision) (flutter/flutter#108356) * 5d31b07 [flutter_tools] [dap] Ensure DAP sends app.stop/app.detach during terminate (flutter/flutter#108310) * c8b5d10 Roll Flutter Engine from 5dcaeae6561b to 89e117b89c63 (1 revision) (flutter/flutter#108367) * e3d08fb Hide the debug banner in the PopupMenuButton example (flutter/flutter#108324)

GaryQian added 4 commits July 21, 2022 17:10

Initial checkout from parent

680056b

Analyze

ffe3cae

Upgrade to Gradle 7.5 and AGP 7.2

2928cd3

Bump some examples and test app gradle versions

476a43f

Remove mirgate command stuff accidentally committed

1a2faa1

GaryQian changed the title ~~Upgrade Gradle and AGP versions to 7.5/7.2.10 and migrate examples/tests~~ Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests Jul 22, 2022

Fix tests

efb2916

GaryQian requested review from camsim99, stuartmorgan-g and zanderso July 22, 2022 23:39

GaryQian mentioned this pull request Jul 25, 2022

Comparison method violates its general contract! error across many Android tests. #103230

Closed

GaryQian added 3 commits July 25, 2022 12:51

Fix test

82128a3

Revert test to 4.1.0 pin

07dc73a

Update plugin build test

123eea2

GaryQian requested a review from christopherfujino July 25, 2022 21:50

christopherfujino approved these changes Jul 25, 2022

View reviewed changes

GaryQian added the waiting for tree to go green label Jul 25, 2022

fluttergithubbot merged commit ca6cecf into flutter:master Jul 25, 2022

zanderso added a commit that referenced this pull request Jul 26, 2022

Revert "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate exampl…

ee48416

…es/tests (#108197)" This reverts commit ca6cecf.

zanderso mentioned this pull request Jul 26, 2022

Revert "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests" #108349

Merged

zanderso added a commit that referenced this pull request Jul 26, 2022

Revert "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate exampl…

d155bc1

…es/tests (#108197)" (#108349) This reverts commit ca6cecf.

GaryQian mentioned this pull request Jul 26, 2022

Reland "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate benchmarks+examples" #108355

Merged

This was referenced Jul 26, 2022

Roll Flutter from fa39206a2a34 to e3d08fb6d325 (23 revisions) flutter/plugins#6147

Merged

Roll Flutter from bbec650b64bc to e3d08fb6d325 (197 revisions) flutter/packages#2383

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 26, 2022

ca6cecf Upgrade Gradle and AGP versions to 7.5/7.2 and migrate exampl…

d999b3a

…es/tests (flutter/flutter#108197)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022

ca6cecf Upgrade Gradle and AGP versions to 7.5/7.2 and migrate exampl…

a0baaa0

…es/tests (flutter/flutter#108197)

engine-flutter-autoroll mentioned this pull request Jul 26, 2022

Roll Flutter from bbec650b64bc to 2f551d30086a (198 revisions) flutter/packages#2384

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022

ca6cecf Upgrade Gradle and AGP versions to 7.5/7.2 and migrate exampl…

8274023

…es/tests (flutter/flutter#108197)

engine-flutter-autoroll mentioned this pull request Jul 26, 2022

Roll Flutter from bbec650b64bc to 527ee1d7286e (199 revisions) flutter/packages#2387

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022

ca6cecf Upgrade Gradle and AGP versions to 7.5/7.2 and migrate exampl…

b310c77

…es/tests (flutter/flutter#108197)

engine-flutter-autoroll mentioned this pull request Jul 26, 2022

Roll Flutter from bbec650b64bc to 87938cec4426 (200 revisions) flutter/packages#2389

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022

ca6cecf Upgrade Gradle and AGP versions to 7.5/7.2 and migrate exampl…

3da6b27

…es/tests (flutter/flutter#108197)

engine-flutter-autoroll mentioned this pull request Jul 26, 2022

Roll Flutter from bbec650b64bc to e05ae3cac799 (202 revisions) flutter/packages#2390

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022

ca6cecf Upgrade Gradle and AGP versions to 7.5/7.2 and migrate exampl…

68fbbd6

…es/tests (flutter/flutter#108197)

engine-flutter-autoroll mentioned this pull request Jul 26, 2022

Roll Flutter from bbec650b64bc to fe16c206ea19 (203 revisions) flutter/packages#2391

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022

ca6cecf Upgrade Gradle and AGP versions to 7.5/7.2 and migrate exampl…

df6fc21

…es/tests (flutter/flutter#108197)

camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022

Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests (…

b1fda46

…flutter#108197)

camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022

Revert "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate exampl…

b2121d7

…es/tests (flutter#108197)" (flutter#108349) This reverts commit ca6cecf.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests #108197

Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests #108197

Uh oh!

GaryQian commented Jul 22, 2022 •

edited

Loading

Uh oh!

christopherfujino commented Jul 25, 2022

Uh oh!

christopherfujino left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests #108197

Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests #108197

Uh oh!

Conversation

GaryQian commented Jul 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

christopherfujino commented Jul 25, 2022

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

GaryQian commented Jul 22, 2022 •

edited

Loading