Skip to content

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Jun 18, 2017

For #10344.

cc @sethladd

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mention "project" here, without defining it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would the definition be? I just meant, like, "Flutter" or "Facebook Flutter Widgets" or whatever.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

library is a defined term. Package is a defined term. Either of those might work?

Or, maybe more simply, "The author of the class defines the categories"... put the responsibility on the author.

(I didn't know if you meant IntelliJ project, or "logical" project, or a user's project?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant project as in "the team of software engineers and other people working on this code". I can make it say "authors" though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Authors" doesn't work. It makes it sound like whoever invents the class gets to invent the categories. Not sure how to make this clearer. I'll try "team"...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, PTAL.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add "optional", because many API docs will have a sufficient one-line doc in their doc comments. I assume @summary is only required when the existing one-line doc isn't sufficient for generated catalogs, etc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see you mention Summary is optional in the Summary API docs.

@sethladd
Copy link
Contributor

this is great, thank you!

lgtm

@sethladd
Copy link
Contributor

love it

lgtm

@Hixie Hixie merged commit 95eba52 into flutter:master Jun 19, 2017
@Hixie Hixie deleted the annotations branch June 19, 2017 17:37
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jul 1, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants