send channel name as a custom dimension #10814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Hixie
reviewed
Jun 19, 2017
| // default as custom dimension 1 (configured in our analytics account). | ||
| _analytics.setSessionValue('dimension1', os.name); | ||
|
|
||
| // Report the branch (or, "channel") name. |
Contributor
There was a problem hiding this comment.
I'd remove this comment (it doesn't really add anything you can't figure out from the code), remove the blank line before it, and then update the earlier comment to cover both cases.
Contributor
|
lgtm w/ Hixie's suggestion |
Contributor
Author
|
@devoncarew @Hixie ptal thanks! |
devoncarew
reviewed
Jun 20, 2017
| // found in the LICENSE file. | ||
|
|
||
| import 'dart:async'; | ||
| import 'dart:io'; |
Contributor
There was a problem hiding this comment.
(I don't believe we generally want to import dart:io in flutter_tools)
Contributor
There was a problem hiding this comment.
Contributor
|
lgtm w/ the removed import |
Contributor
Author
|
Ah, thanks! That was left over from debugging. |
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jul 1, 2017
* send channel name as a custom dimension * tweaks from review * remove unused import
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10696