Text selection handles track scrolled text fields #10805
Conversation
Hixie
changed the title
|
Depends on flutter/engine#3787 to run without failing. |
There was a problem hiding this comment.
I wonder if this would be more efficient in two write calls...
There was a problem hiding this comment.
I bet this would be more efficient as a loop.
There was a problem hiding this comment.
Probably, but not sufficiently to make it worth re-implementing "join" here. :-)
There was a problem hiding this comment.
Maybe phrase this in the past tense since the drawing has already occurred.
There was a problem hiding this comment.
done, also added more information to the docs
There was a problem hiding this comment.
It would be more efficient to add the two offsets before multiplying them into the transform (if both are present).
There was a problem hiding this comment.
added links to widgets
There was a problem hiding this comment.
Either make one line or use { }
There was a problem hiding this comment.
done, to all cases in the file
There was a problem hiding this comment.
Use { } for multiline functions
|
|
Introduce CompositedTransformTarget and CompositedTransformFollower widgets, corresponding render objects, and corresponding layers. Adjust the way text fields work to use this. Various changes I needed to debug the issues that came up.
|
will land on green |
|
@Hixie: I made some tests here and the controls get above the title bar when scrolling. I pull the latest master release. Is it happening with someone else?
|
|
Yeah, that's expected. In your case, I'm guessing you're using a SingleChildListView; switching to a regular ListView should fix it. In the general case, I'm not really sure how to fix it. In a way, it's not really wrong -- the handles are on top of everything, so it makes sense that when you scroll, they'd end up on top. But obviously it's not ideal. |
|
I put it inside a regular ListView but it do not solve the problem. Am I doing something wrong? Another thing. When I first select the text to show controls the buttons do not draw. After the first scroll they appears.
|
|
Well that's not good. Please file bugs, we should fix those things! |
Introduce CompositedTransformTarget and CompositedTransformFollower widgets, corresponding render objects, and corresponding layers. Adjust the way text fields work to use this. Various changes I needed to debug the issues that came up.
4 participants
Introduce CompositedTransformTarget and CompositedTransformFollower
widgets, corresponding render objects, and corresponding layers.
Adjust the way text fields work to use this.
Various changes I needed to debug the issues that came up.
Fixes #3861
cc @abarth