Skip to content

Eliminate use of ideviceinfo in flutter_tools #10804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cbracken merged 1 commit into from
Jun 19, 2017
Merged

Eliminate use of ideviceinfo in flutter_tools #10804

cbracken merged 1 commit into from
Jun 19, 2017

Conversation

@cbracken
Copy link
Member

@cbracken cbracken commented Jun 17, 2017

This libimobiledevice tool is no longer used anywhere in the codebase.

@cbracken
Eliminate use of ideviceinfo
47de9f8 
This libimobiledevice tool is no longer used anywhere in the codebase.
@cbracken cbracken requested a review from tvolkert June 17, 2017 00:51
@Hixie
Copy link
Contributor

Hixie commented Jun 19, 2017

flutter/dev/devicelab/lib/framework/adb.dart

Line 312 in 189028a

final List<String> iosDeviceIds = grep('UniqueDeviceID', from: await eval('ideviceinfo', <String>[]))
?

@cbracken
Copy link
Member Author

cbracken commented Jun 19, 2017 •
edited
Loading

flutter/dev/devicelab/lib/framework/adb.dart

Line 312 in 189028a

final List<String> iosDeviceIds = grep('UniqueDeviceID', from: await eval('ideviceinfo', <String>[]))

Unfortunately I had to roll back a bunch of the work I'd done to eliminate the use of ideviceinfo Friday evening due to issues with the bots (see commit b2909a2). Will sweep up the devicelab use once we've got the revert reverted and flutter_tools free from it. We should be able to use the exact same replacement tooling in devicelab.

@Hixie
Copy link
Contributor

Hixie commented Jun 19, 2017

Ah, got it.

@cbracken cbracken changed the title Eliminate use of ideviceinfo Eliminate use of ideviceinfo in flutter_tools Jun 19, 2017
@cbracken cbracken merged commit 400a62d into flutter:master Jun 19, 2017
@cbracken cbracken deleted the eliminate-ideviceinfo branch June 19, 2017 20:36
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jul 1, 2017
@cbracken @gspencergoog
Eliminate use of ideviceinfo in flutter_tools (flutter#10804)
d489953 
This libimobiledevice tool is no longer used anywhere in the flutter_tools codebase.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@tvolkert tvolkert tvolkert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cbracken @Hixie @tvolkert @googlebot