Skip to content

Revert "Allow setting of TestWidgetsFlutterBinding.pointerEventSource" #108038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dnfield merged 1 commit into from
Jul 20, 2022
Merged

Revert "Allow setting of TestWidgetsFlutterBinding.pointerEventSource" #108038

dnfield merged 1 commit into from
Jul 20, 2022

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Jul 20, 2022

Reverts #107976

@dnfield dnfield requested a review from goderbauer July 20, 2022 18:07
@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Jul 20, 2022
goderbauer
goderbauer approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnfield dnfield merged commit 199cb2f into master Jul 20, 2022
@dnfield dnfield deleted the revert-107976-set_pointereventsource branch July 20, 2022 18:14
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 20, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
a0b1960 
…ntSource (#107976)" (flutter/flutter#108038)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
51a28f9 
…ntSource (#107976)" (flutter/flutter#108038)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
815b93d 
…ntSource (#107976)" (flutter/flutter#108038)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
c4db774 
…ntSource (#107976)" (flutter/flutter#108038)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
3c21df1 
…ntSource (#107976)" (flutter/flutter#108038)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
fe47340 
…ntSource (#107976)" (flutter/flutter#108038)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
567c875 
…ntSource (#107976)" (flutter/flutter#108038)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
013c00c 
…ntSource (#107976)" (flutter/flutter#108038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
231f79a 
…ntSource (#107976)" (flutter/flutter#108038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
fd34b74 
…ntSource (#107976)" (flutter/flutter#108038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
a29a76a 
…ntSource (#107976)" (flutter/flutter#108038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
6a059a5 
…ntSource (#107976)" (flutter/flutter#108038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
84a2c85 
…ntSource (#107976)" (flutter/flutter#108038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
e249341 
…ntSource (#107976)" (flutter/flutter#108038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
601e175 
…ntSource (#107976)" (flutter/flutter#108038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
598e150 
…ntSource (#107976)" (flutter/flutter#108038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
ed896c2 
…ntSource (#107976)" (flutter/flutter#108038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
8e3b039 
…ntSource (#107976)" (flutter/flutter#108038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
598f6ca 
…ntSource (#107976)" (flutter/flutter#108038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
8fcfb29 
…ntSource (#107976)" (flutter/flutter#108038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
5975baf 
…ntSource (#107976)" (flutter/flutter#108038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
a8d47fe 
…ntSource (#107976)" (flutter/flutter#108038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
e37a928 
…ntSource (#107976)" (flutter/flutter#108038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
5a4f040 
…ntSource (#107976)" (flutter/flutter#108038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
313aecf 
…ntSource (#107976)" (flutter/flutter#108038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
fdf4049 
…ntSource (#107976)" (flutter/flutter#108038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
9bfee5a 
…ntSource (#107976)" (flutter/flutter#108038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
354fb3a 
…ntSource (#107976)" (flutter/flutter#108038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
6d3cbab 
…ntSource (#107976)" (flutter/flutter#108038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
ce83c17 
…ntSource (#107976)" (flutter/flutter#108038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
896fea9 
…ntSource (#107976)" (flutter/flutter#108038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
60dd3cf 
…ntSource (#107976)" (flutter/flutter#108038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
452089b 
…ntSource (#107976)" (flutter/flutter#108038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
5cc3aab 
…ntSource (#107976)" (flutter/flutter#108038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
d1f815f 
…ntSource (#107976)" (flutter/flutter#108038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
199cb2f Revert "Allow setting of TestWidgetsFlutterBinding.pointerEve…
79ad382 
…ntSource (#107976)" (flutter/flutter#108038)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@dnfield @camsim99
Revert "Allow setting of TestWidgetsFlutterBinding.pointerEventSource (…
5afe0d3 
…flutter#107976)" (flutter#108038)

This reverts commit 641f4e2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dnfield @goderbauer