Move intrinsics tests to test mode only. #10796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should improve debug-time performance.
Contributor
Author
|
cc @abarth |
abarth
reviewed
Jun 16, 2017
| BoxConstraints get constraints => super.constraints; | ||
|
|
||
| // We check the intrinsic sizes of each render box once by default. | ||
| bool _debugNeedsIntrinsicSizeCheck = true; |
Contributor
There was a problem hiding this comment.
We don't want this in test mode?
Contributor
Author
There was a problem hiding this comment.
In tests I figured we'd just be super aggressive and always test everything. It found a bug! (Sort of. The bug only existed because of the checks.) The 1400 tests still run in under 2 minutes, so the cost seems low.
Contributor
|
|
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jul 1, 2017
This should improve debug-time performance.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should improve debug-time performance.