Extract all libimobiledevice invocations to IMobileDevice class #10793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves all remaining calls to tools that are part of the libimobiledevice suite of tools to the IMobileDevice class. This allows for better tracking of this dependency, and easier mocking in tests.
tvolkert
reviewed
Jun 16, 2017
|
|
||
| import 'dart:async'; | ||
| import 'dart:convert' show JSON; | ||
| import 'dart:io' show ProcessResult; |
Contributor
There was a problem hiding this comment.
base/io.dart (there's a test that'll fail if you try to import dart:io)
tvolkert
approved these changes
Jun 16, 2017
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jul 1, 2017
…ter#10793) Moves all remaining calls to tools that are part of the libimobiledevice suite of tools to the IMobileDevice class. This allows for better tracking of this dependency, and easier mocking in tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves all remaining calls to tools that are part of the libimobiledevice
suite of tools to the IMobileDevice class. This allows for better
tracking of this dependency, and easier mocking in tests.