Skip to content

Delinting future awaits round 1.1 #10786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xster merged 1 commit into from
Jun 16, 2017
Merged

Delinting future awaits round 1.1 #10786

xster merged 1 commit into from
Jun 16, 2017

Conversation

@xster
Copy link
Member

@xster xster commented Jun 16, 2017

Addressing comments in #10760

@xster xster requested review from Hixie and yjbanov June 16, 2017 18:41
@xster xster mentioned this pull request Jun 16, 2017
Merged
yjbanov
yjbanov approved these changes Jun 16, 2017
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xster xster merged commit 0339351 into flutter:master Jun 16, 2017
@xster xster deleted the unawaited-future-1.1 branch June 16, 2017 21:22
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jul 1, 2017
@xster @gspencergoog
address comments (flutter#10786)
d27c98a
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yjbanov yjbanov yjbanov approved these changes

@Hixie Hixie Awaiting requested review from Hixie

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xster @yjbanov @googlebot