modernize iOS device lookup in driver #10780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goderbauer
reviewed
Jun 16, 2017
Member
There was a problem hiding this comment.
Should this comment include macOS now as well?
Contributor
Author
There was a problem hiding this comment.
Oops. Left-over. Gone.
yjbanov
force-pushed
the
modernize-ios-device-lookup
branch
from
cfc7e36 to
403b422
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing logic is back from the days when we didn't know how to run on physical iOS devices, so we attempted to launch a Simulator even when there's a physical iOS device attached. This change removes all that, making macOS+iOS behavior identical to that of Linux/Windows+Android.
Fixes #10773