Eliminate direct invocations of idevice_id for iOS #10777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All invocations should go via the IMobileDevice class in mac.dart.
tvolkert
reviewed
Jun 16, 2017
| class IOSDevice extends Device { | ||
| IOSDevice(String id, { this.name }) : super(id) { | ||
| _installerPath = _checkForCommand('ideviceinstaller'); | ||
| _listerPath = _checkForCommand('idevice_id'); |
Contributor
There was a problem hiding this comment.
If it's no longer used, remove the instance variable and getter too.
tvolkert
approved these changes
Jun 16, 2017
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jul 1, 2017
All invocations should go via the IMobileDevice class in mac.dart.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All invocations should go via the IMobileDevice class in mac.dart.