Skip to content

[flutter_tools] Remove shuffle from doctor test #107744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 13 commits into from
Jul 16, 2022
Merged

[flutter_tools] Remove shuffle from doctor test #107744

auto-submit merged 13 commits into from
Jul 16, 2022

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Jul 15, 2022 •
edited
Loading

Part of #85160
Part of #107607

Rather than directly calling a global that would only be instantiated once during the suite, at which time it would capture the current global FeatureFlags object, expose a new test factory for creating DoctorValidatorsProviders and providing the FeatureFlags to use.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 15, 2022
@christopherfujino christopherfujino marked this pull request as ready for review July 15, 2022 21:01
Jasguerrero
Jasguerrero approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@Jasguerrero Jasguerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino christopherfujino added tool Affects the "flutter" command-line tool. See also t: labels. autosubmit Merge PR when tree becomes green via auto submit App and removed tool Affects the "flutter" command-line tool. See also t: labels. labels Jul 16, 2022
@auto-submit auto-submit bot merged commit 4f95282 into flutter:master Jul 16, 2022
@christopherfujino christopherfujino deleted the remove-shuffle-from-doctor-test branch July 16, 2022 01:18
This was referenced Jul 16, 2022
Merged
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 16, 2022
@engine-flutter-autoroll
4f95282 [flutter_tools] Remove shuffle from doctor test (flutter/flut…
b8ec0d5 
…ter#107744)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2022
@engine-flutter-autoroll
4f95282 [flutter_tools] Remove shuffle from doctor test (flutter/flut…
e9dfd11 
…ter#107744)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
4f95282 [flutter_tools] Remove shuffle from doctor test (flutter/flut…
c9d3402 
…ter#107744)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
4f95282 [flutter_tools] Remove shuffle from doctor test (flutter/flut…
977260d 
…ter#107744)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
4f95282 [flutter_tools] Remove shuffle from doctor test (flutter/flut…
88c6708 
…ter#107744)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
4f95282 [flutter_tools] Remove shuffle from doctor test (flutter/flut…
bebf06c 
…ter#107744)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
4f95282 [flutter_tools] Remove shuffle from doctor test (flutter/flut…
e6cf1d4 
…ter#107744)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
4f95282 [flutter_tools] Remove shuffle from doctor test (flutter/flut…
ff09625 
…ter#107744)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
4f95282 [flutter_tools] Remove shuffle from doctor test (flutter/flut…
1a5bd83 
…ter#107744)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
4f95282 [flutter_tools] Remove shuffle from doctor test (flutter/flut…
1d56e22 
…ter#107744)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
4f95282 [flutter_tools] Remove shuffle from doctor test (flutter/flut…
a01b165 
…ter#107744)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
4f95282 [flutter_tools] Remove shuffle from doctor test (flutter/flut…
a1f2189 
…ter#107744)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
4f95282 [flutter_tools] Remove shuffle from doctor test (flutter/flut…
060a000 
…ter#107744)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
4f95282 [flutter_tools] Remove shuffle from doctor test (flutter/flut…
1689eab 
…ter#107744)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
4f95282 [flutter_tools] Remove shuffle from doctor test (flutter/flut…
865e8ab 
…ter#107744)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
4f95282 [flutter_tools] Remove shuffle from doctor test (flutter/flut…
16d984f 
…ter#107744)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
4f95282 [flutter_tools] Remove shuffle from doctor test (flutter/flut…
d3a2c8b 
…ter#107744)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
4f95282 [flutter_tools] Remove shuffle from doctor test (flutter/flut…
efadf45 
…ter#107744)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
4f95282 [flutter_tools] Remove shuffle from doctor test (flutter/flut…
22434d5 
…ter#107744)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
4f95282 [flutter_tools] Remove shuffle from doctor test (flutter/flut…
a344b76 
…ter#107744)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
4f95282 [flutter_tools] Remove shuffle from doctor test (flutter/flut…
1479cde 
…ter#107744)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
4f95282 [flutter_tools] Remove shuffle from doctor test (flutter/flut…
7cffec4 
…ter#107744)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
4f95282 [flutter_tools] Remove shuffle from doctor test (flutter/flut…
903190f 
…ter#107744)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
4f95282 [flutter_tools] Remove shuffle from doctor test (flutter/flut…
94fd796 
…ter#107744)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
4f95282 [flutter_tools] Remove shuffle from doctor test (flutter/flut…
f653651 
…ter#107744)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
4f95282 [flutter_tools] Remove shuffle from doctor test (flutter/flut…
67e1147 
…ter#107744)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
4f95282 [flutter_tools] Remove shuffle from doctor test (flutter/flut…
894cdff 
…ter#107744)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
4f95282 [flutter_tools] Remove shuffle from doctor test (flutter/flut…
d1ad6f9 
…ter#107744)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
4f95282 [flutter_tools] Remove shuffle from doctor test (flutter/flut…
78c3c51 
…ter#107744)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
4f95282 [flutter_tools] Remove shuffle from doctor test (flutter/flut…
43a1390 
…ter#107744)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
4f95282 [flutter_tools] Remove shuffle from doctor test (flutter/flut…
e101609 
…ter#107744)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
4f95282 [flutter_tools] Remove shuffle from doctor test (flutter/flut…
f6045e7 
…ter#107744)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@christopherfujino @camsim99
[flutter_tools] Remove shuffle from doctor test (flutter#107744)
2772b9e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Jasguerrero Jasguerrero Jasguerrero approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@christopherfujino @Jasguerrero