Skip to content

Fix native platform view integration test config #107679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Jul 15, 2022
Merged

Fix native platform view integration test config #107679

auto-submit merged 1 commit into from
Jul 15, 2022

Conversation

@hellohuanlin
Copy link
Contributor

@hellohuanlin hellohuanlin commented Jul 14, 2022 •
edited
Loading

Fixes #106745 (comment)

It turns out that I have to set the ios OS since android is the default one.

Tested on the github CI (with presubmit flag on).

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jul 14, 2022
@hellohuanlin hellohuanlin force-pushed the huan_fix_native_platform_view_ui_tests_ios branch 2 times, most recently from 70bc41a to 30eda01 Compare July 15, 2022 22:15
@hellohuanlin hellohuanlin force-pushed the huan_fix_native_platform_view_ui_tests_ios branch from 30eda01 to 2913fb4 Compare July 15, 2022 22:16
@hellohuanlin hellohuanlin changed the title [DRAFT] test run Fix native platform view integration test config Jul 15, 2022
@hellohuanlin hellohuanlin requested review from cyanglaz and jmagman July 15, 2022 22:18
@hellohuanlin hellohuanlin marked this pull request as ready for review July 15, 2022 22:18
@hellohuanlin hellohuanlin requested a review from keyonghan as a code owner July 15, 2022 22:18
@hellohuanlin hellohuanlin added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 15, 2022
@auto-submit auto-submit bot merged commit da8070d into flutter:master Jul 15, 2022
This was referenced Jul 16, 2022
Merged
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 16, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
dc6bc06 
…tter#107679)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
dafab38 
…tter#107679)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
88c58bb 
…tter#107679)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
77d994a 
…tter#107679)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
1034b0f 
…tter#107679)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
1f41109 
…tter#107679)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
b29b146 
…tter#107679)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
aff6fde 
…tter#107679)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
7149902 
…tter#107679)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
428b7b1 
…tter#107679)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
1f0d67e 
…tter#107679)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
cc5fd21 
…tter#107679)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
8efb9be 
…tter#107679)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
dd147de 
…tter#107679)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
b595e82 
…tter#107679)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
ec75d4d 
…tter#107679)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
f0faedf 
…tter#107679)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
38e3d71 
…tter#107679)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
9c94838 
…tter#107679)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
a0859cb 
…tter#107679)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
294621c 
…tter#107679)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
b5c7c51 
…tter#107679)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
ad95842 
…tter#107679)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
6795789 
…tter#107679)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
3a38507 
…tter#107679)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
4e3488e 
…tter#107679)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
ce6d4c2 
…tter#107679)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
8d028c7 
…tter#107679)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
86f3fab 
…tter#107679)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
7c6acf3 
…tter#107679)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
c5c0cdf 
…tter#107679)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
2f9d73b 
…tter#107679)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
2662fb5 
…tter#107679)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
4243232 
…tter#107679)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
d1b3418 
…tter#107679)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
da8070d Fix native platform view integration test config (flutter/flu…
4ce61d6 
…tter#107679)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@hellohuanlin @camsim99
Fix native platform view integration test config (flutter#107679)
e85179c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

@keyonghan keyonghan Awaiting requested review from keyonghan

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mac native_platform_view_ui_tests_ios has been failing consistently

2 participants

@hellohuanlin @jmagman