Skip to content

[flutter_tools] Migrate commands.shard/hermetic/doctor_test to null-safety and make hermetic #107670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 8 commits into from
Jul 15, 2022
Merged

[flutter_tools] Migrate commands.shard/hermetic/doctor_test to null-safety and make hermetic #107670

auto-submit merged 8 commits into from
Jul 15, 2022

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Jul 14, 2022

Part of #71511
Part of #107607

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 14, 2022
christopherfujino
christopherfujino commented Jul 14, 2022
View reviewed changes
packages/flutter_tools/lib/src/doctor.dart
Future<bool> diagnose({
bool androidLicenses = false,
bool verbose = true,
bool showColor = true,
Copy link
Contributor Author

@christopherfujino christopherfujino Jul 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be consistent with the rest of the tool, we should check if the terminal supports color, rather than creating a special function parameter only for use in tests

@christopherfujino
Copy link
Contributor Author

christopherfujino commented Jul 15, 2022

@Jasguerrero friendly ping

Jasguerrero
Jasguerrero approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@Jasguerrero Jasguerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 15, 2022
@auto-submit auto-submit bot merged commit 060adf0 into flutter:master Jul 15, 2022
@christopherfujino christopherfujino deleted the make-doctor-test-hermetic branch July 15, 2022 20:12
This was referenced Jul 16, 2022
Merged
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 16, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
7750bd3 
…o null-safety and make hermetic (flutter/flutter#107670)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
0ca2b48 
…o null-safety and make hermetic (flutter/flutter#107670)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
0a13a5f 
…o null-safety and make hermetic (flutter/flutter#107670)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
2697517 
…o null-safety and make hermetic (flutter/flutter#107670)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
61cb3e0 
…o null-safety and make hermetic (flutter/flutter#107670)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
bfebb55 
…o null-safety and make hermetic (flutter/flutter#107670)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
1641a94 
…o null-safety and make hermetic (flutter/flutter#107670)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
b22963e 
…o null-safety and make hermetic (flutter/flutter#107670)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
1084e32 
…o null-safety and make hermetic (flutter/flutter#107670)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
e36705b 
…o null-safety and make hermetic (flutter/flutter#107670)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
f965a6b 
…o null-safety and make hermetic (flutter/flutter#107670)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
f6c06e8 
…o null-safety and make hermetic (flutter/flutter#107670)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
4ff02a2 
…o null-safety and make hermetic (flutter/flutter#107670)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
92c6416 
…o null-safety and make hermetic (flutter/flutter#107670)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
42f3dd2 
…o null-safety and make hermetic (flutter/flutter#107670)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
8b3d75e 
…o null-safety and make hermetic (flutter/flutter#107670)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
3617f4e 
…o null-safety and make hermetic (flutter/flutter#107670)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
d124c26 
…o null-safety and make hermetic (flutter/flutter#107670)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
f7c7357 
…o null-safety and make hermetic (flutter/flutter#107670)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
77d4993 
…o null-safety and make hermetic (flutter/flutter#107670)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
dcc9a87 
…o null-safety and make hermetic (flutter/flutter#107670)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
59fddb1 
…o null-safety and make hermetic (flutter/flutter#107670)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
fa256f0 
…o null-safety and make hermetic (flutter/flutter#107670)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
2fd6b1f 
…o null-safety and make hermetic (flutter/flutter#107670)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
c9c61cc 
…o null-safety and make hermetic (flutter/flutter#107670)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
a02fd38 
…o null-safety and make hermetic (flutter/flutter#107670)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
12efc8f 
…o null-safety and make hermetic (flutter/flutter#107670)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
108ead3 
…o null-safety and make hermetic (flutter/flutter#107670)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
7f7927c 
…o null-safety and make hermetic (flutter/flutter#107670)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
d2c5e1d 
…o null-safety and make hermetic (flutter/flutter#107670)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
4ef1951 
…o null-safety and make hermetic (flutter/flutter#107670)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
1a96c12 
…o null-safety and make hermetic (flutter/flutter#107670)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
6d79adc 
…o null-safety and make hermetic (flutter/flutter#107670)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
d0d8324 
…o null-safety and make hermetic (flutter/flutter#107670)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
4d62d01 
…o null-safety and make hermetic (flutter/flutter#107670)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
da91079 
…o null-safety and make hermetic (flutter/flutter#107670)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
060adf0 [flutter_tools] Migrate commands.shard/hermetic/doctor_test t…
c993ada 
…o null-safety and make hermetic (flutter/flutter#107670)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@christopherfujino @camsim99
[flutter_tools] Migrate commands.shard/hermetic/doctor_test to null-s…
8e78575 
…afety and make hermetic (flutter#107670)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Jasguerrero Jasguerrero Jasguerrero approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@christopherfujino @Jasguerrero