Skip to content

Read dart_plugin_registrant path from FlutterProject to support non-standard path. #107617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Jul 15, 2022
Merged

Read dart_plugin_registrant path from FlutterProject to support non-standard path. #107617

fluttergithubbot merged 1 commit into from
Jul 15, 2022

Conversation

@chingjun
Copy link
Contributor

@chingjun chingjun commented Jul 14, 2022

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 14, 2022
christopherfujino
christopherfujino approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 8f834cf into flutter:master Jul 15, 2022
This was referenced Jul 16, 2022
Merged
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 16, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
67c11ad 
…rt non-standard path. (flutter/flutter#107617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
34d0d7a 
…rt non-standard path. (flutter/flutter#107617)
@zanderso zanderso mentioned this pull request Jul 18, 2022
Closed
christopherfujino added a commit that referenced this pull request Jul 18, 2022
@christopherfujino
Revert "Read dart_plugin_registrant path from FlutterProject to suppo…
7184c9f 
…rt non-standard path. (#107617)"

This reverts commit 8f834cf.
@christopherfujino christopherfujino mentioned this pull request Jul 18, 2022
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
83510ff 
…rt non-standard path. (flutter/flutter#107617)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
c23974c 
…rt non-standard path. (flutter/flutter#107617)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
dce5e10 
…rt non-standard path. (flutter/flutter#107617)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
834cb5a 
…rt non-standard path. (flutter/flutter#107617)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
00c3d9d 
…rt non-standard path. (flutter/flutter#107617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
16ae9c6 
…rt non-standard path. (flutter/flutter#107617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
aff0e91 
…rt non-standard path. (flutter/flutter#107617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
5d40f1d 
…rt non-standard path. (flutter/flutter#107617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
8910297 
…rt non-standard path. (flutter/flutter#107617)
@chingjun chingjun mentioned this pull request Jul 19, 2022
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
97c45d0 
…rt non-standard path. (flutter/flutter#107617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
65d1958 
…rt non-standard path. (flutter/flutter#107617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
3e23a40 
…rt non-standard path. (flutter/flutter#107617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
37e50dc 
…rt non-standard path. (flutter/flutter#107617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
b3edb0a 
…rt non-standard path. (flutter/flutter#107617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
ab2e7bd 
…rt non-standard path. (flutter/flutter#107617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
a86b812 
…rt non-standard path. (flutter/flutter#107617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
cec505f 
…rt non-standard path. (flutter/flutter#107617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
dd0c822 
…rt non-standard path. (flutter/flutter#107617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
e2f5dc3 
…rt non-standard path. (flutter/flutter#107617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
941e090 
…rt non-standard path. (flutter/flutter#107617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
35b5697 
…rt non-standard path. (flutter/flutter#107617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
f5c8f09 
…rt non-standard path. (flutter/flutter#107617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
cf7dee1 
…rt non-standard path. (flutter/flutter#107617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
0d3ccd4 
…rt non-standard path. (flutter/flutter#107617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
ef475d5 
…rt non-standard path. (flutter/flutter#107617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
672ec54 
…rt non-standard path. (flutter/flutter#107617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
02d0a51 
…rt non-standard path. (flutter/flutter#107617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
3188ef5 
…rt non-standard path. (flutter/flutter#107617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
e577082 
…rt non-standard path. (flutter/flutter#107617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
f916c48 
…rt non-standard path. (flutter/flutter#107617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
0707835 
…rt non-standard path. (flutter/flutter#107617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
e88f7f3 
…rt non-standard path. (flutter/flutter#107617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
0d1e71b 
…rt non-standard path. (flutter/flutter#107617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
b5a63b1 
…rt non-standard path. (flutter/flutter#107617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
9573789 
…rt non-standard path. (flutter/flutter#107617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
874bb4e 
…rt non-standard path. (flutter/flutter#107617)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
8f834cf Read dart_plugin_registrant path from FlutterProject to suppo…
61d0628 
…rt non-standard path. (flutter/flutter#107617)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@chingjun @camsim99
Read dart_plugin_registrant path from FlutterProject to support non-s…
e226559 
…tandard path. (flutter#107617)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaaclarke gaaclarke Awaiting requested review from gaaclarke

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chingjun @christopherfujino @fluttergithubbot