Align doubles to 8 bytes in the StandardMessageCodec #10758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
mravn-google
approved these changes
Jun 16, 2017
Contributor
mravn-google
left a comment
mravn-google
left a comment
There was a problem hiding this comment.
We need to add a unit test for this.
Otherwise, LGTM
Member
Author
|
Added a test of the new encoding to message_codecs_test |
Contributor
|
Thanks! |
tvolkert
approved these changes
Jun 16, 2017
Contributor
tvolkert
left a comment
tvolkert
left a comment
There was a problem hiding this comment.
The Chromium bots are done with the engine builds, so you can rev the engine to 784e9756720f7f6daa15c95ba3df6215bb54783f in this now.
Then LGTM!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #10701