[flutter_tools] Catch more general XmlException rather than XmlParserException #107574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
| document = XmlDocument.parse(manifestFile.readAsStringSync()); | ||
| } on XmlParserException { | ||
| return false; | ||
| } on XmlTagException { |
Contributor
Author
There was a problem hiding this comment.
Here I had previously added additional handling for XmlTagException, however this wouldn't have caught an XmlParentException or XmlNodeTypeException
christopherfujino
added
the
autosubmit
This was referenced Jul 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jul 14, 2022
christopherfujino
added a commit
to chris-forks/flutter
that referenced
this pull request
Aug 2, 2022
itsjustkevin
pushed a commit
that referenced
this pull request
Aug 8, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106365
In package:xml, there are many possible types of exceptions that could be thrown from an invalid Xml document; however, historically the tool has only caught XmlParserException. This changes the exception handling to catch instead the abstract parent class,
XmlException; we want to handle ALL types of invalid XML documents and direct the user to repair it themselves.