Skip to content

Add an interactive example for Overlay #107531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Jul 15, 2022
Merged

Add an interactive example for Overlay #107531

auto-submit merged 1 commit into from
Jul 15, 2022

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Jul 13, 2022

fixes #100895

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jul 13, 2022
@TahaTesser TahaTesser requested a review from goderbauer July 13, 2022 11:17
@goderbauer
Copy link
Member

goderbauer commented Jul 13, 2022

@LongCatIsLooong You have recently worked a lot with overlays. Would you be up for taking a look at this?

LongCatIsLooong
LongCatIsLooong reviewed Jul 13, 2022
View reviewed changes
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simulator Screen Shot - iPad Pro (12 9-inch) (5th generation) - 2022-07-13 at 11 27 30

It looks like on some devices the hard coded height (80) doesn't work that well. But since it's going to be rendered in a browser I'm not sure if that matters?

examples/api/lib/widgets/overlay/overlay.0.dart Outdated
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong Jul 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to point to the wrong section if the writing direction is RTL.

Copy link
Member Author

@TahaTesser TahaTesser Jul 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added AlignmentDirectional just in case, the example itself won't update tho in RTL.

examples/api/lib/widgets/overlay/overlay.0.dart Outdated
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works but preferably currentPageIndex should be updated before the overlay entry.

Copy link
Member Author

@TahaTesser TahaTesser Jul 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@TahaTesser
Copy link
Member Author

TahaTesser commented Jul 14, 2022 •
edited
Loading

It looks like on some devices the hard coded height (80) doesn't work that well. But since it's going to be rendered in a browser I'm not sure if that matters?

I can see this when testing on the iOS simulator so I've added SafeArea in OverlayEntry.

Preview

LongCatIsLooong
LongCatIsLooong approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but you probably don't need the if in removeHighlightOverlay now.

@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 15, 2022
@auto-submit auto-submit bot merged commit cf34225 into flutter:master Jul 15, 2022
@TahaTesser TahaTesser deleted the overlay_example branch July 15, 2022 09:57
This was referenced Jul 15, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 15, 2022
@engine-flutter-autoroll
cf34225 Add an interactive example for Overlay (flutter/flutter#107531
2ed98c9 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2022
@engine-flutter-autoroll
cf34225 Add an interactive example for Overlay (flutter/flutter#107531
3a15d9c 
)
@TahaTesser TahaTesser mentioned this pull request Jul 21, 2022
Closed
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@TahaTesser @camsim99
Add an interactive example for Overlay (flutter#107531)
c594838
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LongCatIsLooong LongCatIsLooong LongCatIsLooong approved these changes

@goderbauer goderbauer Awaiting requested review from goderbauer

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Overlay: Add an example showcasing how Overlay can be used to highlight part of the UI

3 participants

@TahaTesser @goderbauer @LongCatIsLooong