Inject iOS, Android workflows via context #10750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminates the need for the device/daemon code to get at the iOS/Android tooling indirectly via Doctor. In tests, we now inject the workflow objects (or mocks) directly.
tvolkert
reviewed
Jun 15, 2017
| import 'android_sdk.dart'; | ||
| import 'android_studio.dart' as android_studio; | ||
|
|
||
| AndroidWorkflow get androidWorkflow => context[AndroidWorkflow]; |
Contributor
There was a problem hiding this comment.
This will alleviate us from having to aggressively inject it everywhere (like Fuchsia and google-internal)
context.putIfAbsent(AndroidWorkflow, () => new AndroidWorkflow())
tvolkert
reviewed
Jun 15, 2017
| import '../doctor.dart'; | ||
| import 'mac.dart'; | ||
|
|
||
| IOSWorkflow get iosWorkflow => context[IOSWorkflow]; |
Contributor
There was a problem hiding this comment.
Same here - ... => context.putIfAbsent(...)
tvolkert
reviewed
Jun 15, 2017
| } | ||
|
|
||
| class MockAndroidWorkflow extends AndroidWorkflow { | ||
| MockAndroidWorkflow({this.canListDevices}); |
tvolkert
reviewed
Jun 15, 2017
|
|
||
| class MockIosWorkflow extends IOSWorkflow { | ||
| class MockIOSWorkflow extends IOSWorkflow { | ||
| MockIOSWorkflow({this.canListDevices}); |
Member
Author
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jul 1, 2017
Eliminates the need for the device/daemon code to get at the iOS/Android tooling indirectly via Doctor. In tests, we now inject the workflow objects (or mocks) directly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates the need for the device/daemon code to get at the iOS/Android
tooling indirectly via Doctor. In tests, we now inject the workflow
objects (or mocks) directly.