Remerge "Fixed AnimatedSwitcher chain produced duplicates" after fixing issues with g3 #107476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
framework
Contributor
|
RSLGTM |
dkwingsmt
approved these changes
Jul 12, 2022
youssef-attia
deleted the
revert-107318-revert-106962-animated_switcher_fix
branch
youssef-attia
added
the
autosubmit
youssef-attia
restored the
revert-107318-revert-106962-animated_switcher_fix
branch
youssef-attia
deleted the
revert-107318-revert-106962-animated_switcher_fix
branch
youssef-attia
restored the
revert-107318-revert-106962-animated_switcher_fix
branch
youssef-attia
deleted the
revert-107318-revert-106962-animated_switcher_fix
branch
This was referenced Feb 23, 2023
jimgerth
added a commit
to jimgerth/flutter
that referenced
this pull request
Feb 28, 2023
Revert the changes introduced by flutter#107476, as they do not completely fix the issue of duplicate keys in the AnimatedSwitcher switcher as demonstrated by flutter#121336, and introduce behavior that deviates from the AnimatedSwitcher's documentation. Specifically, children that are transitioning out are immediately removed from the widget tree, if another child with the same key is added, while the AnimatedSwitcher is clearly supposed to support multiple children with the same key transitioning in and out at the same time according to its documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #107318