-
Notifications
You must be signed in to change notification settings - Fork 29.7k
[flutter_tools] Replace android v2 embedding broken doc link #107456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flutter_tools] Replace android v2 embedding broken doc link #107456
Conversation
Replaces the now broken, removed go link for migrating to android v2 embedding with the link hosted at the Flutter wiki.
319d5db to
bdbe1f5
Compare
| throwToolExit( | ||
| 'The plugin `${plugin['name']}` requires your app to be migrated to ' | ||
| 'the Android embedding v2. Follow the steps on https://flutter.dev/go/android-project-migration ' | ||
| 'the Android embedding v2. Follow the steps on the migration doc above ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this message is displayed, the tool should also display the embedding warning, which already includes the doc link.
christopherfujino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks LGTM
Jasguerrero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Replaces the now broken, removed go link for migrating to android v2
embedding with the link hosted at the Flutter wiki.
Fixes #107437
flutter/website#7337 for additional context.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.