Revert "InputDecorator: Switch hint to Opacity instead of AnimatedOpacity"
#107406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This reverts commit 255b71f.
flutter-dashboard
bot
added
a: text input
CaseyHillers
added
the
autosubmit
HansMuller
approved these changes
Jul 11, 2022
This was referenced Jul 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jul 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 12, 2022
This was referenced Jul 18, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
auto-submit bot
pushed a commit
that referenced
this pull request
Sep 21, 2023
…tion (#135211) ## Description This PR adds a parameter to configure the input decorator hint fade transition duration. This animation is not part of the Material specification. Removing it was considered but it breaks internal tests (see #107406). I also considered several ways to avoid the fade animation (setting duration to 0, removing the hint text, etc) but it breaks many existing tests that assumes the hint text to be visible. To mitigate the issue in a non disruptive way, I set the default duration to 20ms (an arbitrary short value). ## Related Issue Fixes #20283. ## Tests Adds 3 tests, updates 3 tests.
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
…tion (flutter#135211) ## Description This PR adds a parameter to configure the input decorator hint fade transition duration. This animation is not part of the Material specification. Removing it was considered but it breaks internal tests (see flutter#107406). I also considered several ways to avoid the fade animation (setting duration to 0, removing the hint text, etc) but it breaks many existing tests that assumes the hint text to be visible. To mitigate the issue in a non disruptive way, I set the default duration to 20ms (an arbitrary short value). ## Related Issue Fixes flutter#20283. ## Tests Adds 3 tests, updates 3 tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #107156
This broke some tests inside Google (b/238490639)