Skip to content

Added support for M3 filled and filled tonal buttons. #107382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
darrenaustin merged 7 commits into from
Aug 25, 2022
Merged

Added support for M3 filled and filled tonal buttons. #107382

darrenaustin merged 7 commits into from
Aug 25, 2022

Conversation

@darrenaustin
Copy link
Contributor

@darrenaustin darrenaustin commented Jul 11, 2022

Followup to #100794.

This adds support for the filled and filled tonal Material Design 3 buttons:

Screen Shot 2022-07-10 at 5 33 28 PM

To create a filled button use the new FilledButton and to create a tonal variant, use FilledButton.tonal:

  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(colorSchemeSeed: const Color(0xff6750a4), useMaterial3: true),
      home: Scaffold(
        appBar: AppBar(title: const Text('FilledButton Sample')),
        body: Center(
          child:  Column(
            children: <Widget>[
              FilledButton(
                onPressed: () {},
                child: const Text('Filled'),
              ),
              FilledButton.tonal(
                onPressed: () {},
                child: Text('Filled tonal'),
              ),
            ]
          ),
          // ...

Fixes: #104357

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jul 11, 2022
guidezpl
guidezpl approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  _    ___ _____ __  __ 
 | |  / __|_   _|  \/  |
 | |_| (_ | | | | |\/| |
 |____\___| |_| |_|  |_|

Looks great! Minor comments about documentation and token usage

guidezpl
guidezpl reviewed Jul 11, 2022
View reviewed changes
Reprevise
Reprevise reviewed Jul 11, 2022
View reviewed changes
@bernaferrari bernaferrari mentioned this pull request Jul 13, 2022
Closed
thipokch
thipokch reviewed Jul 15, 2022
View reviewed changes
HansMuller
HansMuller approved these changes Jul 23, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM however there are many comments from @guidezpl that merit response/changes.

@rydmike
Copy link
Contributor

rydmike commented Aug 12, 2022

This will also close #104357, hope it lands in master soon so it can make it to next stable release.

@rydmike rydmike mentioned this pull request Aug 12, 2022
Closed
70 tasks
albertms10
albertms10 reviewed Aug 12, 2022
View reviewed changes
@darrenaustin
Copy link
Contributor Author

darrenaustin commented Aug 23, 2022

This will also close #104357, hope it lands in master soon so it can make it to next stable release.

Sorry this has taken a while. There is an internal Google naming conflict that we need to resolve before we can land this (as well as I was out for a couple weeks vacation). Hopefully this should land in the next couple of days.

@rydmike
Copy link
Contributor

rydmike commented Aug 24, 2022

No worries @darrenaustin, I suspect this one won't make it to next stable. It looked so ready that I just thought it would be a pity to wait for it another 3-4 months for the next release after the assumed imminent one. However, there are so many other feature gaps and issues with M3 opt-in in Beta 3.3.0-x and even master, that I can't recommend opting in on M3 for Flutter projects yet anyway. This one was rather small from that point of view, since you can compose/configure this style already when needed.

@darrenaustin darrenaustin merged commit 5454bab into flutter:master Aug 25, 2022
@darrenaustin darrenaustin deleted the m3_button_variant branch August 25, 2022 20:16
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 25, 2022
@engine-flutter-autoroll
5454bab Added support for M3 filled and filled tonal buttons. (flutte…
a0f4748 
…r/flutter#107382)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 26, 2022
@engine-flutter-autoroll
5454bab Added support for M3 filled and filled tonal buttons. (flutte…
f778bd6 
…r/flutter#107382)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
@engine-flutter-autoroll
5454bab Added support for M3 filled and filled tonal buttons. (flutte…
09694cf 
…r/flutter#107382)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
@engine-flutter-autoroll
5454bab Added support for M3 filled and filled tonal buttons. (flutte…
3854897 
…r/flutter#107382)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
@engine-flutter-autoroll
5454bab Added support for M3 filled and filled tonal buttons. (flutte…
6744b19 
…r/flutter#107382)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
@engine-flutter-autoroll
5454bab Added support for M3 filled and filled tonal buttons. (flutte…
c63c79a 
…r/flutter#107382)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
@engine-flutter-autoroll
5454bab Added support for M3 filled and filled tonal buttons. (flutte…
49ebfe9 
…r/flutter#107382)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
@engine-flutter-autoroll
5454bab Added support for M3 filled and filled tonal buttons. (flutte…
3810916 
…r/flutter#107382)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
@engine-flutter-autoroll
5454bab Added support for M3 filled and filled tonal buttons. (flutte…
24ffadb 
…r/flutter#107382)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
@engine-flutter-autoroll
5454bab Added support for M3 filled and filled tonal buttons. (flutte…
7ae3139 
…r/flutter#107382)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
@engine-flutter-autoroll
5454bab Added support for M3 filled and filled tonal buttons. (flutte…
457c7ea 
…r/flutter#107382)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
@engine-flutter-autoroll
5454bab Added support for M3 filled and filled tonal buttons. (flutte…
0ed3079 
…r/flutter#107382)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
@engine-flutter-autoroll
5454bab Added support for M3 filled and filled tonal buttons. (flutte…
4f97ec3 
…r/flutter#107382)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
@engine-flutter-autoroll
5454bab Added support for M3 filled and filled tonal buttons. (flutte…
1a65264 
…r/flutter#107382)
CaseyHillers added a commit that referenced this pull request Aug 28, 2022
@CaseyHillers
Revert "Added support for M3 filled and filled tonal buttons. (#107382)"
449dcf4 
This reverts commit 5454bab.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 29, 2022
@engine-flutter-autoroll
5454bab Added support for M3 filled and filled tonal buttons. (flutte…
5c766dc 
…r/flutter#107382)
@rydmike rydmike mentioned this pull request Sep 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guidezpl guidezpl guidezpl approved these changes

@QuncCccccc QuncCccccc Awaiting requested review from QuncCccccc

+4 more reviewers

@HansMuller HansMuller HansMuller approved these changes

@thipokch thipokch thipokch left review comments

@Reprevise Reprevise Reprevise left review comments

@albertms10 albertms10 albertms10 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Proposal] Add filled buttons as per material 3 guidelines

7 participants

@darrenaustin @rydmike @HansMuller @guidezpl @thipokch @Reprevise @albertms10