Remove redundant build, and pod install steps from benchmarks #10736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
+1 to removing redundant build and pod install. Unsure about provisioning profiles. Have you tried it with corporate-issues provisioning profiles (as opposed to personal profiles)? |
Member
Author
|
Keeping the provisioning step, removing the extra build and pod install steps. PTAL. |
goderbauer
changed the title
yjbanov
approved these changes
Jun 16, 2017
| objects = { | ||
|
|
||
| /* Begin PBXBuildFile section */ | ||
| 1498D2341E8E89220040F4C2 /* GeneratedPluginRegistrant.m in Sources */ = {isa = PBXBuildFile; fileRef = 1498D2331E8E89220040F4C2 /* GeneratedPluginRegistrant.m */; }; |
Contributor
There was a problem hiding this comment.
Not sure what's going on in this file.
Member
|
Does this work if there were multiple certs on the machine prompting a choice? Or does it fall in with #10626 too? (e.g. --machine) |
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jul 1, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like these are no longer required as flutter will now handle these automatically. This should speed up our benchmarks.
Fixes #10729
Fixes #10697