Ensure flutter run build is done in incremental mode. #107184
Conversation
This allows for faster bootstrapping of the compiler from previously created dill file. Fixes flutter#107183
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
the
tool
|
SkiaPerf isn't reporting any changes to debug_compile_after_edit_millis, but there are some small improvements to other compilation benchmarks: |
|
I think I looked at https://flutter-flutter-perf.skia.org/e/?keys=X0f98c584e08529729191ceafb3d77338 which showed ~30% performance improvement for that benchmark |
* Ensure build is done in incremental mode. This allows for faster bootstrapping of the compiler from previously created dill file. Fixes flutter#107183 * Avoid initializeFromDill in aot mode * Update tests
3 participants
This allows for faster bootstrapping of the compiler from the previously created dill file.
Recently added benchmark debug_compile_after_edit_millis will track the improvement.
Fixes #107183