Skip to content

Conversation

@jonahwilliams
Copy link
Contributor

I'm pretty sure that 0.0 times anything is 0.0. Except for maybe infinity, but don't quote me on that.

Fixes #106974

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Jul 2, 2022
@jonahwilliams jonahwilliams requested a review from flar July 2, 2022 00:13
@flar
Copy link
Contributor

flar commented Jul 2, 2022

I'm pretty sure that 0.0 times anything is 0.0. Except for maybe infinity, but don't quote me on that.

But a transform is a sum of 3 or 4 factors some of which can be zero... ;)

Copy link
Contributor

@flar flar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a typo nit...

@jonahwilliams jonahwilliams requested a review from flar July 7, 2022 17:04
Copy link
Contributor

@flar flar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonahwilliams
Copy link
Contributor Author

Thanks @flar !

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 7, 2022
@auto-submit auto-submit bot merged commit 1573934 into flutter:master Jul 7, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 8, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 8, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 8, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 8, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transform.scale and ScaleTransform should avoid painting/compositing when scale is 0

2 participants