Enable Windows platform_channel test #106973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
d: examples
Fixes and enables the platform_channel integration test for Windows. Because Windows devices don't necessarily have batteries, the Windows implementation has been updated to return a specific error for cases where there is no battery, and the example handles that error with specific UI instead of a failure message. The integration test has been updated to allow that response as a valid response so that the test will pass on machines without batteries.
stuartmorgan-g
force-pushed
the
windows-platform-channel-enable-test
branch
from
8e9e90d to
1119513
Compare
stuartmorgan-g
commented
Jul 1, 2022
| ["devicelab", "hostonly"] | ||
| task_name: platform_channel_sample_test_windows | ||
| scheduler: luci | ||
| bringup: true |
Contributor
Author
There was a problem hiding this comment.
I validated (by temporarily making this a presubmit test in an earlier version of this PR) that this test passes with the changes here.
stuartmorgan-g
added
the
autosubmit
Contributor
|
auto-submit
bot
removed
the
autosubmit
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jul 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jul 6, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes and enables the platform_channel integration test for Windows.
Because Windows devices don't necessarily have batteries, the Windows
implementation has been updated to return a specific error for cases
where there is no battery, and the example handles that error with
specific UI instead of a failure message.
The integration test has been updated to allow that response as a
valid response so that the test will pass on machines without
batteries.
Pre-launch Checklist
///).