Skip to content

[Keyboard, iOS] Generate iOS's special key mapping #106909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 9 commits into from
Jul 13, 2022
Merged

[Keyboard, iOS] Generate iOS's special key mapping #106909

auto-submit merged 9 commits into from
Jul 13, 2022

Conversation

@dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented Jun 30, 2022 •
edited
Loading

This PR accompanies flutter/engine#34413 by generating a table of "special key mapping" for iOS.

This table has also been used by RawKeyboardIos in the framework, but has been hard-coded. With this PR, this hard-coded table is also generated by the script.

This PR should not need tests, since it only contains changes to auto-generation scrip and a refactor.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jun 30, 2022
@flutter-dashboard
Copy link

flutter-dashboard bot commented Jun 30, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@dkwingsmt dkwingsmt requested a review from gspencergoog June 30, 2022 23:09
@dkwingsmt dkwingsmt added a: text input Entering text in a text field or keyboard related problems platform-ios iOS applications specifically labels Jun 30, 2022
@Hixie
Copy link
Contributor

Hixie commented Jun 30, 2022

test-exempt: code refactor with no semantic change

gspencergoog
gspencergoog approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

(once the tests pass)

@dkwingsmt dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 9, 2022
@jmagman
Copy link
Member

jmagman commented Jul 13, 2022

@dkwingsmt Google testing seems stuck?

@auto-submit auto-submit bot merged commit d87faf9 into flutter:master Jul 13, 2022
This was referenced Jul 14, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2022
@engine-flutter-autoroll
d87faf9 [Keyboard, iOS] Generate iOS's special key mapping (flutter/f…
8e1c78c 
…lutter#106909)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 14, 2022
@engine-flutter-autoroll
d87faf9 [Keyboard, iOS] Generate iOS's special key mapping (flutter/f…
b971fc0 
…lutter#106909)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@dkwingsmt @camsim99
[Keyboard, iOS] Generate iOS's special key mapping (flutter#106909)
26444ec
@jmagman jmagman mentioned this pull request Apr 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. platform-ios iOS applications specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dkwingsmt @Hixie @jmagman @gspencergoog