Skip to content

Clarify that inputFormatters don't run on programmatical changes #106904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 2 commits into from
Jul 6, 2022
Merged

Clarify that inputFormatters don't run on programmatical changes #106904

fluttergithubbot merged 2 commits into from
Jul 6, 2022

Conversation

@LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented Jun 30, 2022

Closes #106821
Also updated the default font size in the documentation to be 14.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@LongCatIsLooong
- Clarify that inputFormatters don't run on programmatical changes
3a90c15 
- Update the default font size in the documentation to be 14.
@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Jun 30, 2022
@LongCatIsLooong LongCatIsLooong requested a review from justinmc June 30, 2022 20:55
goderbauer
goderbauer approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

justinmc
justinmc approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks for updating these docs, hopefully that clears up the confusion.

packages/flutter/lib/src/painting/text_style.dart
///
/// If this is false, properties that don't have explicit values will revert
/// to the defaults: white in color, a font size of 10 pixels, in a sans-serif
/// to the defaults: white in color, a font size of 14 pixels, in a sans-serif
Copy link
Contributor

@justinmc justinmc Jul 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@fluttergithubbot fluttergithubbot merged commit 0a06644 into flutter:master Jul 6, 2022
@LongCatIsLooong LongCatIsLooong added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Jul 6, 2022
@LongCatIsLooong LongCatIsLooong deleted the inputFormatter-documentation branch July 6, 2022 23:24
This was referenced Jul 7, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2022
@engine-flutter-autoroll
0a06644 Clarify that inputFormatters don't run on programmatical chan…
4985fbc 
…ges (flutter/flutter#106904)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 7, 2022
@engine-flutter-autoroll
0a06644 Clarify that inputFormatters don't run on programmatical chan…
5aa8537 
…ges (flutter/flutter#106904)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@LongCatIsLooong @camsim99
Clarify that inputFormatters don't run on programmatical changes (flu…
98cef44 
…tter#106904)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
0a06644 Clarify that inputFormatters don't run on programmatical chan…
69eb870 
…ges (flutter/flutter#106904)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
0a06644 Clarify that inputFormatters don't run on programmatical chan…
9db09c0 
…ges (flutter/flutter#106904)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Setting text through TextEditingController.text doesn't apply the TextInputFormatters

4 participants

@LongCatIsLooong @justinmc @goderbauer @fluttergithubbot