Reland "Disable cursor opacity animation on macOS, make iOS cursor animation discrete (#104335)" #106893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
animation discrete (flutter#104335)" (reverted in flutter#106762) This reverts commit 8124191.
flutter-dashboard
bot
added
a: text input
LongCatIsLooong
commented
Jun 30, 2022
| // Selection should stay the same since it is set on tap up for mobile platforms. | ||
| await touchGesture.down(gPos); | ||
| await tester.pumpAndSettle(); | ||
| await tester.pump(); |
Contributor
Author
There was a problem hiding this comment.
Had to change 2 tests since the test gesture was meant to be a tap but ended up being a long press.
Contributor
Author
There was a problem hiding this comment.
@Renzo-Olivares are you ok with this change?
Contributor
Author
|
No relevant failures on test TGP run. Ready for review. |
Renzo-Olivares
approved these changes
Jul 8, 2022
Contributor
Renzo-Olivares
left a comment
Renzo-Olivares
left a comment
There was a problem hiding this comment.
LGTM I'm okay with the test changes.
LongCatIsLooong
added
the
autosubmit
This was referenced Jul 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 9, 2022
…ursor animation discrete (#104335)" (flutter/flutter#106893)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jul 9, 2022
…ursor animation discrete (#104335)" (flutter/flutter#106893)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jul 9, 2022
…ursor animation discrete (#104335)" (flutter/flutter#106893)
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
…ursor animation discrete (#104335)" (flutter/flutter#106893)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
…ursor animation discrete (#104335)" (flutter/flutter#106893)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TGP => OCL:459558623:BASE:459559716:1657240390400:7a09b29b
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.