Skip to content

Scroll inertia cancel [framework] #106891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Jul 21, 2022
Merged

Scroll inertia cancel [framework] #106891

auto-submit merged 3 commits into from
Jul 21, 2022

Conversation

@moffatman
Copy link
Contributor

@moffatman moffatman commented Jun 30, 2022 •
edited
Loading

It's expected behaviour on some platforms that scroll inertia/momentum animations will stop when a finger is rested on the trackpad. This PR reacts to a new kind of pointer signal event (PointerSignalKind.scrollInertiaCancel) to convey that message.

Framework prep PR: #106906

Engine PR [1/4]: flutter/engine#34402

Part of #106979

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests f: gestures flutter/packages/flutter/gestures repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Jun 30, 2022
@moffatman moffatman mentioned this pull request Jun 30, 2022
Merged
8 tasks
@HansMuller HansMuller requested a review from dkwingsmt July 1, 2022 21:43
@moffatman moffatman mentioned this pull request Jul 7, 2022
Merged
8 tasks
@moffatman moffatman force-pushed the inertia branch 2 times, most recently from e840a4c to ccd259b Compare July 8, 2022 04:11
This was referenced Jul 8, 2022
Closed
Merged
@goderbauer
Copy link
Member

goderbauer commented Jul 13, 2022

(Triage): Looks like the Engine PR has been submitted, does this one need to be rebased to pick up the engine changes and make the tests happy?

@dkwingsmt
Copy link
Contributor

dkwingsmt commented Jul 13, 2022 •
edited
Loading

This one needs to be merged after flutter/engine#34537 is rolled in. flutter/engine#34537 was waiting for another prerequisite, but should be now ready. Let's get flutter/engine#34537 merged first.

dkwingsmt
dkwingsmt reviewed Jul 14, 2022
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally okay except for a few questions.

packages/flutter/test/widgets/scrollable_test.dart Outdated
Copy link
Contributor

@dkwingsmt dkwingsmt Jul 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just record the exact result (and possibly remove the first try)?

Copy link
Contributor Author

@moffatman moffatman Jul 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's dependent on exact scroll friction calculation. I hadn't recorded the exact result since I am working on some related change (the scroll friction right now has been tuned for touch, it causes much more momentum than native trackpad scrolling apps). But I can change it to the exact result now and change again later.

dkwingsmt
dkwingsmt approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/flutter/test/widgets/scrollable_test.dart Outdated
Copy link
Contributor

@dkwingsmt dkwingsmt Jul 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we don't need the first try any more, since we no longer need the distance to compare with?

@moffatman moffatman added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 21, 2022
@auto-submit auto-submit bot merged commit 22f51c3 into flutter:master Jul 21, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
22f51c3 Scroll inertia cancel [framework] (flutter/flutter#106891)
179bd1d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
22f51c3 Scroll inertia cancel [framework] (flutter/flutter#106891)
78573e0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
22f51c3 Scroll inertia cancel [framework] (flutter/flutter#106891)
bd9e9f1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
22f51c3 Scroll inertia cancel [framework] (flutter/flutter#106891)
1eb7699
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
22f51c3 Scroll inertia cancel [framework] (flutter/flutter#106891)
5f91c28
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 23, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
22f51c3 Scroll inertia cancel [framework] (flutter/flutter#106891)
3f7f2a7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 23, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
22f51c3 Scroll inertia cancel [framework] (flutter/flutter#106891)
9308e5c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 24, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
22f51c3 Scroll inertia cancel [framework] (flutter/flutter#106891)
88084d1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 24, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
22f51c3 Scroll inertia cancel [framework] (flutter/flutter#106891)
fcdcf64
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
22f51c3 Scroll inertia cancel [framework] (flutter/flutter#106891)
27b0650
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
22f51c3 Scroll inertia cancel [framework] (flutter/flutter#106891)
cb32fc0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
22f51c3 Scroll inertia cancel [framework] (flutter/flutter#106891)
892a015
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
22f51c3 Scroll inertia cancel [framework] (flutter/flutter#106891)
8f99919
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
22f51c3 Scroll inertia cancel [framework] (flutter/flutter#106891)
eca19fe
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
22f51c3 Scroll inertia cancel [framework] (flutter/flutter#106891)
85c3baf
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
22f51c3 Scroll inertia cancel [framework] (flutter/flutter#106891)
d09c030
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
22f51c3 Scroll inertia cancel [framework] (flutter/flutter#106891)
da5e7d6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
22f51c3 Scroll inertia cancel [framework] (flutter/flutter#106891)
01e7be4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
22f51c3 Scroll inertia cancel [framework] (flutter/flutter#106891)
be71632
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
22f51c3 Scroll inertia cancel [framework] (flutter/flutter#106891)
7cff05a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
22f51c3 Scroll inertia cancel [framework] (flutter/flutter#106891)
b699e2d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
22f51c3 Scroll inertia cancel [framework] (flutter/flutter#106891)
b6eb3e6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
22f51c3 Scroll inertia cancel [framework] (flutter/flutter#106891)
26ef1a2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
22f51c3 Scroll inertia cancel [framework] (flutter/flutter#106891)
76f8856
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
22f51c3 Scroll inertia cancel [framework] (flutter/flutter#106891)
0bf71ff
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
22f51c3 Scroll inertia cancel [framework] (flutter/flutter#106891)
cf40eb9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
22f51c3 Scroll inertia cancel [framework] (flutter/flutter#106891)
f9fc77b
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@moffatman @camsim99
Scroll inertia cancel [framework] (flutter#106891)
bc588df
@Piinks Piinks mentioned this pull request Dec 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkwingsmt dkwingsmt dkwingsmt approved these changes

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App f: gestures flutter/packages/flutter/gestures repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@moffatman @goderbauer @dkwingsmt