Don't disable pointer interaction during trackpad scroll #106890
Conversation
flutter-dashboard
bot
added
f: scrolling
moffatman
force-pushed
the
trackpad_scrollable_interactive
branch
from
f4b062d to
64ee8bd
Compare
| expect(find.text('Page 9'), findsOneWidget); | ||
| }); | ||
|
|
||
| testWidgets('Scroll device type controls whether pointer is ignored.', (WidgetTester tester) async { |
There was a problem hiding this comment.
| testWidgets('Scroll device type controls whether pointer is ignored.', (WidgetTester tester) async { | |
| testWidgets('Pointer is not ignored during trackpad scrolling.', (WidgetTester tester) async { |
moffatman
force-pushed
the
trackpad_scrollable_interactive
branch
2 times, most recently
from
77de568 to
486756b
Compare
moffatman
force-pushed
the
trackpad_scrollable_interactive
branch
from
486756b to
f7ff2fa
Compare
|
A test is failing because |
Was being lazy with testing the trackpad processing. I added some proper event synthesis functions and used those instead. |
|
Fly-by comment from triage: looks like the analyzer is unhappy. |
moffatman
force-pushed
the
trackpad_scrollable_interactive
branch
from
2c128a0 to
1c8623e
Compare
|
cc @Piinks |
| super.delegate, | ||
| Simulation simulation, | ||
| TickerProvider vsync, | ||
| this.shouldIgnorePointer, |
There was a problem hiding this comment.
This might be a breaking change, let me run some internal tests first. One way to work around this is to make it an optional parameter with a default behavior.
There was a problem hiding this comment.
Actually I was able to do a quick look up and found no uses of this class internally. ✅
There was a problem hiding this comment.
I did find a breakage in an external package while testing this with my existing code, but they were only overriding BallisticScrollActivity to perform the exact same function as here.
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
What happens if the user tries to drag again before the activity finishes? Will it crash? I see the test checks for tapping, but what if the user tries to drag scroll? I think the scroll view might throw because it can only have one active drag at a time..
|
|
Just double checking common crashes when we make changes like these. 😉 |
4 participants
Usually pointer interaction is disabled during a drag scroll. Now that trackpad uses a continuous/drag scroll, this should be changed so that mouse hover effects and clicking is possible as it was before recent changes.
Fixes #105308
Pre-launch Checklist
///).